Skip to content

Conversation

@popcornmix
Copy link
Contributor

Explicitly report kms/fkms/legacy and labwc/wwayfire/Xorg and generally tidy up

report libcamera-hello output if installed

Add sudo to dmesg

Explicitly report kms/fkms/legacy and labwc/wwayfire/Xorg and generally tidy up
You can configure the kernel to require root to access dmesg.
Lets use sudo anyway - we already do in other places in this script
@macmpi
Copy link
Contributor

macmpi commented Oct 26, 2025

Add sudo to dmesg

Now there are many sudo uses in this script (which gates implicit sudo dependency for downstream packages), how about warning upfront this script should be run with administrator privileges like:
! [ "$(id -u)" -eq 0 ] && { echo >&2 "Please run with administrator privileges."; exit 1; }
or do "escape tests" in various places?

@popcornmix popcornmix merged commit f05444f into raspberrypi:master Oct 26, 2025
@popcornmix
Copy link
Contributor Author

Requiring sudo for raspinfo is beyond the scope of this PR.
There will be documentation and guides that will become incorrect after this change.

It's certainly something to consider.

A lighter change would be to only invoke sudo when it is needed (i.e.. raspinfo has not been invoked with sudo).

@macmpi
Copy link
Contributor

macmpi commented Oct 26, 2025

How about testing upfront if sudo is available then, and warning/quitting if not?
This would not be disruptive to PiOS users probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants