Fixed download URL for Helm chart #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the download URL from the release tagged with v0.3.0 instead of the latest release, which just returns the ray-cluster Helm chart Signed-off-by: Sigmund Vestergaard <sigmundv@gmail.com>
|
LGTM |
kevin85421
approved these changes
Sep 16, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Get the download URL from the release tagged with v0.3.0 instead of the latest release, which just returns the ray-cluster Helm chart Signed-off-by: Sigmund Vestergaard <sigmundv@gmail.com> Signed-off-by: Sigmund Vestergaard <sigmundv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the download URL from the release tagged with v0.3.0 instead of the latest release, which just returns the ray-cluster Helm chart
Signed-off-by: Sigmund Vestergaard sigmundv@gmail.com
Why are these changes needed?
The instructions given in
helm-chart/kuberay-operator/README.mddon't work, because the command that gets the download URL is wrong. This PR fixes the command such that it gets the correct download URL.NOTE: The proposed fix gets the chart from release v0.3.0, but you might want to get it from the latest release, which is a different tag.
Related issue number
Fixes #569
Checks