[core] Congratulate the user for a ray check failure and ask them to file an issue #55276

dayshah · 2025-08-06T00:26:09Z

Why are these changes needed?

We want people to report ray check failures more and make them feel less bad after their ray cluster crashes.

Signed-off-by: dayshah <dhyey2019@gmail.com>

gemini-code-assist

Summary of Changes

Hello @dayshah, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've implemented a change to improve the user experience when a Ray check fails. The goal is to transform a potentially frustrating event into a positive interaction by providing a more encouraging message that congratulates the user for finding a bug and guides them on how to report it, thereby fostering more community contributions to bug fixing.

Highlights

Enhanced User Experience for Ray Check Failures: I've updated the RAY_CHECK_WITH_DISPLAY macro in src/ray/util/logging.h to change the message displayed when a Ray check fails. The new message is designed to be more encouraging, congratulating the user for discovering a bug and providing clear instructions, including a link, on how to report the issue on GitHub.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist · 2025-08-06T00:35:07Z

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

can-anyscale · 2025-08-06T00:34:51Z

src/ray/util/logging.h

+           << " Congratulations! A check failed, this means you discovered a bug in " \
+              "Ray that made the system behave in an unexpected way. Please report "  \
+              "this issue at https://github.com/ray-project/ray/issues for extra "    \
+              "credit points and it'll (hopefully) get fixed ASAP! : " display " ")


lol, can we still keep the " Check failed: " display " at the end of the message, that way the go/core/crashes stuff will still be working link

israbbani · 2025-08-06T00:36:29Z

src/ray/util/logging.h

+  ? RAY_IGNORE_EXPR(0)                                                                \
+  : ::ray::Voidify() &                                                                \
+          (::ray::RayLog(__FILE__, __LINE__, ray::RayLogLevel::FATAL)                 \
+           << " Congratulations! A check failed, this means you discovered a bug in " \
+              "Ray that made the system behave in an unexpected way. Please report "  \
+              "this issue at https://github.com/ray-project/ray/issues for extra "    \
+              "credit points and it'll (hopefully) get fixed ASAP! : " display " ")


Not what I had in mind

Signed-off-by: dayshah <dhyey2019@gmail.com>

can-anyscale

can-anyscale · 2025-08-06T17:09:26Z

src/ray/util/logging.h

+           << " Congratulations! This means you discovered a bug in Ray that made the " \
+              "system behave in an unexpected way. Please report this issue at "        \
+              "https://github.com/ray-project/ray/issues for extra credit points and "  \
+              "it'll (hopefully) get fixed ASAP! Check failed: " display " ")


I would perhaps remove hopefully, it doesn't project confidence

true, removed

Signed-off-by: dayshah <dhyey2019@gmail.com>

src/ray/util/logging.h

Co-authored-by: Ibrahim Rabbani <israbbani@gmail.com> Signed-off-by: Dhyey Shah <dhyey2019@gmail.com>

Signed-off-by: dayshah <dhyey2019@gmail.com>

edoakes · 2025-08-06T20:33:52Z

src/ray/util/logging.h

+  : ::ray::Voidify() &                                                             \
+          (::ray::RayLog(__FILE__, __LINE__, ray::RayLogLevel::FATAL)              \
+           << " Congratulations! You've discovered a bug in Ray that made the "    \
+              "system behave in an unexpected way. Please report this issue at "   \
+              "https://github.com/ray-project/ray/issues and we'll try to fix it " \
+              "ASAP! Check failed: " display " ")


It's a little too tongue-in-cheek IMO. Would prefer something more straightforward:

Suggested change

: ::ray::Voidify() & \

(::ray::RayLog(__FILE__, __LINE__, ray::RayLogLevel::FATAL) \

<< " Congratulations! You've discovered a bug in Ray that made the " \

"system behave in an unexpected way. Please report this issue at " \

"https://github.com/ray-project/ray/issues and we'll try to fix it " \

"ASAP! Check failed: " display " ")

: ::ray::Voidify() & \

(::ray::RayLog(__FILE__, __LINE__, ray::RayLogLevel::FATAL) \

<< " An unexpected system state has occurred. You have likely " \

"discovered a bug in Ray. Please report this issue at " \

"https://github.com/ray-project/ray/issues and we'll work with you to fix it. " \

"Check failed: " display " ")

the user will feel unappreciated for their usage 😞

Signed-off-by: dayshah <dhyey2019@gmail.com>

…file an issue (ray-project#55276) Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Dhyey Shah <dhyey2019@gmail.com> Co-authored-by: Ibrahim Rabbani <israbbani@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>

…file an issue (#55276) Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Dhyey Shah <dhyey2019@gmail.com> Co-authored-by: Ibrahim Rabbani <israbbani@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: sampan <sampan@anyscale.com>

…file an issue (ray-project#55276) Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Dhyey Shah <dhyey2019@gmail.com> Co-authored-by: Ibrahim Rabbani <israbbani@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Andrew Grosser <dioptre@gmail.com>

…file an issue (ray-project#55276) Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Dhyey Shah <dhyey2019@gmail.com> Co-authored-by: Ibrahim Rabbani <israbbani@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>

…file an issue (#55276) Signed-off-by: dayshah <dhyey2019@gmail.com> Signed-off-by: Dhyey Shah <dhyey2019@gmail.com> Co-authored-by: Ibrahim Rabbani <israbbani@gmail.com> Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>

dayshah added 2 commits August 5, 2025 17:23

Add ray check message asking users to report

d9bd3e8

Signed-off-by: dayshah <dhyey2019@gmail.com>

congratulations

c96e888

Signed-off-by: dayshah <dhyey2019@gmail.com>

dayshah added the go add ONLY when ready to merge, run all tests label Aug 6, 2025

dayshah requested a review from a team as a code owner August 6, 2025 00:26

gemini-code-assist bot reviewed Aug 6, 2025

View reviewed changes

can-anyscale reviewed Aug 6, 2025

View reviewed changes

israbbani reviewed Aug 6, 2025

View reviewed changes

dayshah added 2 commits August 5, 2025 22:19

Fix test

bff0b10

Signed-off-by: dayshah <dhyey2019@gmail.com>

up

1fc3151

Signed-off-by: dayshah <dhyey2019@gmail.com>

can-anyscale approved these changes Aug 6, 2025

View reviewed changes

no hopefully

0014df6

Signed-off-by: dayshah <dhyey2019@gmail.com>

israbbani reviewed Aug 6, 2025

View reviewed changes

src/ray/util/logging.h Outdated Show resolved Hide resolved

dayshah and others added 2 commits August 6, 2025 11:24

Update src/ray/util/logging.h

f710fa8

Co-authored-by: Ibrahim Rabbani <israbbani@gmail.com> Signed-off-by: Dhyey Shah <dhyey2019@gmail.com>

fix lint + test

d074d42

Signed-off-by: dayshah <dhyey2019@gmail.com>

edoakes requested changes Aug 6, 2025

View reviewed changes

dayshah added 2 commits August 6, 2025 20:40

Merge branch 'master' into ray-check-msg

16d6a45

Signed-off-by: dayshah <dhyey2019@gmail.com>

ed's boring message

1351a8f

Signed-off-by: dayshah <dhyey2019@gmail.com>

edoakes approved these changes Aug 7, 2025

View reviewed changes

Merge branch 'master' into ray-check-msg

eafba70

edoakes enabled auto-merge (squash) August 7, 2025 22:06

github-actions bot disabled auto-merge August 7, 2025 22:06

Merge branch 'master' into ray-check-msg

42d6b36

dayshah enabled auto-merge (squash) August 10, 2025 03:12

dayshah merged commit 96036f7 into ray-project:master Aug 10, 2025
6 checks passed

dayshah deleted the ray-check-msg branch August 11, 2025 03:19

[core] Congratulate the user for a ray check failure and ask them to file an issue #55276

[core] Congratulate the user for a ray check failure and ask them to file an issue #55276

Uh oh!

Conversation

dayshah commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are these changes needed?

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot commented Aug 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

can-anyscale left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dayshah commented Aug 6, 2025 •

edited

Loading