Skip to content

feat: deprecate put asset #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2022
Merged

feat: deprecate put asset #128

merged 1 commit into from
May 19, 2022

Conversation

@mabdh
Copy link
Member

@mabdh mabdh commented May 17, 2022

No description provided.

@mabdh mabdh linked an issue May 17, 2022 that may be closed by this pull request
deprecate PUT /v1beta1/assets #112
Closed
@mabdh mabdh requested a review from StewartJingga May 17, 2022 07:27
@mabdh mabdh marked this pull request as ready for review May 17, 2022 07:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2336990647

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 81.332%
Files with Coverage Reduction New Missed Lines %
api/v1beta1/asset.go 12 77.93%
Totals Coverage Status
Change from base Build 2336211886: -0.3%
Covered Lines: 4422
Relevant Lines: 5437
💛 - Coveralls

@StewartJingga StewartJingga merged commit 2a32bb0 into main May 19, 2022
@StewartJingga StewartJingga deleted the deprecate-put-asset branch May 19, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

deprecate PUT /v1beta1/assets

4 participants

@mabdh @coveralls @StewartJingga