fix: json schema for kube config #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishanarya0
approved these changes
Mar 1, 2023
rohilsurana
reviewed
Mar 6, 2023
| "type": "string" | ||
| }, | ||
| "cluster_ca_certificate": { | ||
| "client_ca_certificate": { |
There was a problem hiding this comment.
In go struct this is mentioned as cluster_ca_certificate
There was a problem hiding this comment.
any specific reason we chose to rename this field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the kube config validation schema to enforce:
hostmust be present and should be a valid URIinsecureoptional (defaults to false)tokenORclient_key, client_certificatepair must be present.insecure=falseand token is not used, thenclient_ca_certificatemust be present.