Skip to content

refactor(frontier): deprecate redundant request parameters from subscription RPC #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

refactor(frontier): deprecate redundant request parameters from subscription RPC #435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8302d9f
deprecate billing id from request payload for subscription
whoAbhishekSah Nov 18, 2025
536197c
remove org id as not needed
whoAbhishekSah Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 72 additions & 24 deletions raystack/frontier/v1beta1/frontier.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2080,12 +2080,23 @@ message TotalDebitedTransactionsResponse {
}

message GetSubscriptionRequest {
string org_id = 1 [(validate.rules).string.min_len = 3];
// DEPRECATED: org_id will be inferred from subscription id
string org_id = 1 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
min_len: 3
}
];
// DEPRECATED: billing_id will be inferred from subscription id
// ID of the billing account to get the subscription for
string billing_id = 2 [(validate.rules).string = {
ignore_empty: true,
uuid: true
}];
string billing_id = 2 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
uuid: true
}
];
// ID of the subscription to get
string id = 3 [(validate.rules).string.min_len = 1];

Expand All @@ -2098,11 +2109,15 @@ message GetSubscriptionResponse {

message ListSubscriptionsRequest {
string org_id = 1 [(validate.rules).string.min_len = 3];
// DEPRECATED: billing_id will be inferred from org_id
// ID of the billing account to list subscriptions for
string billing_id = 2 [(validate.rules).string = {
ignore_empty: true,
uuid: true
}];
string billing_id = 2 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
uuid: true
}
];

// Filter subscriptions by state
string state = 3;
Expand All @@ -2117,12 +2132,23 @@ message ListSubscriptionsResponse {
}

message UpdateSubscriptionRequest {
string org_id = 1 [(validate.rules).string.min_len = 3];
// DEPRECATED: org_id will be inferred from subscription id
string org_id = 1 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
min_len: 3
}
];
// DEPRECATED: billing_id will be inferred from subscription id
// ID of the billing account to update the subscription for
string billing_id = 2 [(validate.rules).string = {
ignore_empty: true,
uuid: true
}];
string billing_id = 2 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
uuid: true
}
];
// ID of the subscription to update
string id = 3 [(validate.rules).string.min_len = 1];

Expand All @@ -2135,12 +2161,23 @@ message UpdateSubscriptionResponse {
}

message ChangeSubscriptionRequest {
string org_id = 1 [(validate.rules).string.min_len = 3];
// DEPRECATED: org_id will be inferred from subscription id
string org_id = 1 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
min_len: 3
}
];
// DEPRECATED: billing_id will be inferred from subscription id
// ID of the billing account to update the subscription for
string billing_id = 2 [(validate.rules).string = {
ignore_empty: true,
uuid: true
}];
string billing_id = 2 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
uuid: true
}
];
// ID of the subscription to update
string id = 3 [(validate.rules).string.min_len = 1];

Expand Down Expand Up @@ -2175,12 +2212,23 @@ message ChangeSubscriptionResponse {
}

message CancelSubscriptionRequest {
string org_id = 1 [(validate.rules).string.min_len = 3];
// DEPRECATED: org_id will be inferred from subscription id
string org_id = 1 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
min_len: 3
}
];
// DEPRECATED: billing_id will be inferred from subscription id
// ID of the billing account to update the subscription for
string billing_id = 2 [(validate.rules).string = {
ignore_empty: true,
uuid: true
}];
string billing_id = 2 [
deprecated = true,
(validate.rules).string = {
ignore_empty: true,
uuid: true
}
];
// ID of the subscription to cancel
string id = 3 [(validate.rules).string.min_len = 1];

Expand Down
Loading