Removed parentValue's initial value #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Set' having a remove button
michealharrington
force-pushed
the
bugfix/for_raysuelzer-bad-initial-parentValue
branch
from
bd5e958 to
39db96f
Compare
Owner
|
So with this change, the remove button no longer shows up on the root ruleset? |
Author
|
Exactly.
… On Aug 10, 2022, at 3:09 PM, Ray Suelzer ***@***.***> wrote:
So with this change, the remove button no longer shows up on the root ruleset?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Owner
|
Sorry for the delay on this. I will merge, it but want to do it when I also have time to update the package. |
Owner
|
@michealharrington sorry this took so long! It's published version 0.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the parentValue has an initial value, the first 'RuleSet' has a remove button that doesn't function.
I removed the default more closely match the original version here: https://github.com/zebzhao/Angular-QueryBuilder/blob/master/projects/angular2-query-builder/src/lib/query-builder/query-builder.component.ts#L126