-
Notifications
You must be signed in to change notification settings - Fork 51
feat: support dotnet 9+ extract interface code action #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
razzmatazz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Though ideally I want to have tests added to ensure that something has actually been fixed here and prevent regressions.
Absolutely, I'll add some tests. I was testing locally swapping out the mason-installed csharp-ls with my build to make sure it was now working. I noticed that there were 3 separate changes to the function call from .NET 8 -> .NET 9.0.100 -> .NET 9.0.300, where the |
|
@razzmatazz I've added some tests (and parallelized the test execution), also moved the task helper to an extension function |
|
There is a lot of whitespace/formatting changes in this PR which makes it a bit hard to read.. |
Yeah, really sorry for that, I didn't turn off my formatter (fantomas) and by the time I noticed it was too late. I can try to detangle it and create a new PR somehow |
Sorry for poking holes in your PR :( I added a linter step in #271 w/ fantomas 7.0.3 (which has caused yet more reformatting). |
…type fix: undo formatting changes from rebase
|
@razzmatazz I believe the PR is in a good state to be reviewed now, no more formatting changes clogging up the diffs |
|
Thank you! This is an outstanding PR. |
|
This has been released as part of 0.20.0: https://www.nuget.org/packages/csharp-ls/0.20.0 |
Resolves #266