pass all core-tests about socket #105
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add right checks in socket and pass the rest core-tests (ReadIntoBadBuffer、WriteFromBadBuffer).
But there is some doubts about my change in zircon-syscall::vmar::sys_vmar_map.
I comment these codes which make sense because in core-tests of socket, an address is mapped as not readable, not writable and not executable, which should be ok but leads to errors due to the code above. However, a page with no rights is useless and only occurs in tests.
The implementation in zircon is same as zCore which doesn't care options and perm_xxxx. I am clear about the meanings of options::perm_xxxx, but without them, the rest core-tests will fail. (QAQ
😓😓😓😓