Skip to content

Conversation

@PanQL
Copy link
Collaborator

@PanQL PanQL commented May 12, 2020

  • add thread-time support

Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use timer_now() to get time in nanoseconds instead of TSC?

@wangrunji0408 wangrunji0408 changed the title add hal_read_tsc Support thread time May 12, 2020
@wangrunji0408 wangrunji0408 merged commit 124a810 into rcore-os:master May 12, 2020
@wangrunji0408 wangrunji0408 added the enhancement New feature or request label May 14, 2020
@wangrunji0408
Copy link
Member

wangrunji0408 commented May 18, 2020

WARN: performance regression detected on qemu-kvm!

Reason: Reading CPUID(major) and TSC(minor) is expensive in virtual machine.

zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
@coveralls
Copy link

coveralls commented Jul 14, 2024

Pull Request Test Coverage Report for Build 102161501

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 2 files are covered.
  • 33 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-2.2%) to 23.677%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zircon-syscall/src/time.rs 0 2 0.0%
zircon-object/src/task/thread.rs 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/async-std-1.5.0/src/task/task.rs 1 64.29%
zircon-syscall/src/time.rs 1 0.0%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/spin-0.5.2/src/mutex.rs 2 91.67%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/async-task-1.3.1/src/utils.rs 5 61.54%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/async-task-1.3.1/src/raw.rs 10 61.64%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/async-std-1.5.0/src/task/builder.rs 14 51.72%
Totals Coverage Status
Change from base Build 101591891: -2.2%
Covered Lines: 1696
Relevant Lines: 7163

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 102142936

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 2 files are covered.
  • 36 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-2.3%) to 23.619%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zircon-syscall/src/time.rs 0 2 0.0%
zircon-object/src/task/thread.rs 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/async-std-1.5.0/src/task/task.rs 1 64.29%
zircon-object/src/object/mod.rs 1 66.86%
zircon-syscall/src/time.rs 1 0.0%
kernel-hal/src/dummy.rs 2 6.67%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/spin-0.5.2/src/mutex.rs 2 91.67%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/async-task-1.3.1/src/utils.rs 5 61.54%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/async-task-1.3.1/src/raw.rs 10 60.73%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/async-std-1.5.0/src/task/builder.rs 14 51.72%
Totals Coverage Status
Change from base Build 101591891: -2.3%
Covered Lines: 1693
Relevant Lines: 7168

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants