socket-datagram #39
Closed
socket-datagram #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete debug print run cargo clippy
Pull Request Test Coverage Report for Build 107314994
💛 - Coveralls |
| const SOCKET_CONTROL_READABLE = 1 << 6; | ||
| const SOCKET_CONTROL_WRITABLE = 1 << 7; | ||
| const SCOEKT_ACCEPT = 1 << 8; | ||
| const SOCKET_SHARE = 1 << 9; |
Member
There was a problem hiding this comment.
reorder them between 5 and 10
| let _peer = self.peer.upgrade().ok_or(ZxError::PEER_CLOSED)?; | ||
| if inner.read_disabled { | ||
| /// Write data to the socket. | ||
| pub fn write(&self, options: SocketFlags, data: &[u8], count: usize) -> ZxResult<usize> { |
Member
There was a problem hiding this comment.
count is unnecessary, it's equal to data.len()
zircon-object/src/ipc/socket.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub fn write_control(&self, data: &[u8], count: usize) -> ZxResult<usize> { |
Member
There was a problem hiding this comment.
remove pub for internal functions
Member
|
And don't forget to run |
cargo fmt and clippy
Pull Request Test Coverage Report for Build 106667640Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add datagram for socket, set capacity limit for socket.
pass almost all core-tests, two of which failed due to a bug of vmar