Skip to content

Conversation

@DeathWish5
Copy link
Contributor

improve socket code:
delete redundant parameter 'count'.
reorder socket signals.
run cargo fmt and clippy.

deathwish5 added 2 commits May 16, 2020 23:59
delete debug print

run cargo clippy
cargo fmt and clippy
@coveralls
Copy link

Pull Request Test Coverage Report for Build 107321440

  • 0 of 91 (0.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 22.208%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zircon-syscall/src/socket.rs 0 23 0.0%
zircon-object/src/ipc/socket.rs 0 68 0.0%
Files with Coverage Reduction New Missed Lines %
zircon-object/src/ipc/socket.rs 6 0%
Totals Coverage Status
Change from base Build 106305047: -0.08%
Covered Lines: 1702
Relevant Lines: 7664

💛 - Coveralls

@wangrunji0408
Copy link
Member

Emmm, no need to open a new PR. Just force-push to the PR branch.

@wangrunji0408 wangrunji0408 added the enhancement New feature or request label May 17, 2020
@wangrunji0408 wangrunji0408 self-requested a review May 17, 2020 15:14
@wangrunji0408 wangrunji0408 merged commit 2742aa6 into rcore-os:master May 17, 2020
zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
* socket datagram and limited size

delete debug print

run cargo clippy

* improve socket code

cargo fmt and clippy

Co-authored-by: deathwish5 <zyr16@mails.tsinghua.edu.cn>
@coveralls
Copy link

coveralls commented Jul 14, 2024

Pull Request Test Coverage Report for Build 107321440

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 91 (0.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 22.208%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zircon-syscall/src/socket.rs 0 23 0.0%
zircon-object/src/ipc/socket.rs 0 68 0.0%
Files with Coverage Reduction New Missed Lines %
zircon-object/src/ipc/socket.rs 6 0.0%
Totals Coverage Status
Change from base Build 106305047: -0.08%
Covered Lines: 1702
Relevant Lines: 7664

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants