Skip to content

Conversation

@benpigchu
Copy link
Contributor

This PR include lots of bug fix to PCI, so it now works (partially) on qemu

  • device tree outputted by dm dump list PCI devices correctly
  • lsblk outputs the blocks in the AHCI disk correctly
  • gpt init gpt dump gpt add gpt edit works, new partition is created, the fuchsia-data type is added successfully. (a kernal panic caused by user space page fault occurs after the gpt edit)
  • mkfs with minfs completes without errors. However if we reboot the machine after that, the fshost will try to mount the filesystem on the disk as minfs, but it will fail since the magic bytes in the journal superblock is not correct.

We used commands from #53 for testing.

Also, the PR added proc name and thread name to the output when the kernal panic on a unhandled user exception. And as a workaround to a page fault caused by a message sent from virtual-console to sysmem driver, we disabled virtual-console in kernal cmdline.

The shell will be usable after this on debug version of zCore on qemu.

@coveralls
Copy link

coveralls commented Jun 14, 2020

Pull Request Test Coverage Report for Build 134942584

  • 0 of 41 (0.0%) changed or added relevant lines in 8 files are covered.
  • 16 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.06%) to 20.13%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zircon-object/src/dev/pci/mod.rs 0 1 0.0%
zircon-object/src/dev/pci/bus.rs 0 2 0.0%
zircon-syscall/src/object.rs 0 2 0.0%
zircon-syscall/src/pci.rs 0 2 0.0%
zircon-object/src/dev/pci/caps.rs 0 5 0.0%
zircon-object/src/dev/pci/nodes.rs 0 5 0.0%
kernel-hal-bare/src/arch/x86_64/interrupt.rs 0 8 0.0%
zircon-object/src/dev/pci/config.rs 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
kernel-hal-bare/src/arch/x86_64/interrupt.rs 1 0%
zircon-object/src/dev/pci/bus.rs 1 0%
zircon-object/src/dev/pci/nodes.rs 1 0%
zircon-object/src/dev/pci/config.rs 2 0%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/numeric-enum-macro-0.2.0/src/lib.rs 4 0%
zircon-object/src/dev/pci/mod.rs 7 0%
Totals Coverage Status
Change from base Build 133046386: -0.06%
Covered Lines: 2040
Relevant Lines: 10134

💛 - Coveralls

@wangrunji0408 wangrunji0408 added the bug Something isn't working label Jun 14, 2020
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orz!

@wangrunji0408 wangrunji0408 merged commit cc4c928 into rcore-os:master Jun 14, 2020
zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
Fixes and workarounds about PCI on qemu
@coveralls
Copy link

coveralls commented Jul 14, 2024

Pull Request Test Coverage Report for Build 134940005

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 41 (0.0%) changed or added relevant lines in 8 files are covered.
  • 46 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.06%) to 20.132%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zircon-object/src/dev/pci/mod.rs 0 1 0.0%
zircon-object/src/dev/pci/bus.rs 0 2 0.0%
zircon-syscall/src/object.rs 0 2 0.0%
zircon-syscall/src/pci.rs 0 2 0.0%
zircon-object/src/dev/pci/caps.rs 0 5 0.0%
zircon-object/src/dev/pci/nodes.rs 0 5 0.0%
kernel-hal-bare/src/arch/x86_64/interrupt.rs 0 8 0.0%
zircon-object/src/dev/pci/config.rs 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
zircon-object/src/dev/pci/bus.rs 1 0.0%
zircon-object/src/dev/pci/nodes.rs 1 0.0%
zircon-object/src/dev/pci/config.rs 2 0.0%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/numeric-enum-macro-0.2.0/src/lib.rs 4 0.0%
zircon-object/src/dev/pci/mod.rs 7 0.0%
kernel-hal-bare/src/arch/x86_64/interrupt.rs 31 0.0%
Totals Coverage Status
Change from base Build 133046386: -0.06%
Covered Lines: 2040
Relevant Lines: 10133

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants