Skip to content

Conversation

@equation314
Copy link
Member

@equation314 equation314 commented Jun 29, 2020

  1. Two syscalls (clock_create, clock_update) unimplemented.
  2. Wrong implemention of job_set_critical which does not consider ancestor of jobs.

@coveralls
Copy link

coveralls commented Jun 29, 2020

Pull Request Test Coverage Report for Build 151511857

  • 1 of 27 (3.7%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 22.685%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zircon-syscall/src/task.rs 0 1 0.0%
zircon-object/src/task/job.rs 0 3 0.0%
zircon-syscall/src/time.rs 0 6 0.0%
zircon-object/src/task/process.rs 1 17 5.88%
Files with Coverage Reduction New Missed Lines %
zircon-syscall/src/time.rs 1 0%
zircon-object/src/task/job.rs 2 57.14%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/hashbrown-0.7.2/src/raw/mod.rs 4 45.96%
Totals Coverage Status
Change from base Build 150314444: -0.08%
Covered Lines: 2068
Relevant Lines: 9116

💛 - Coveralls

@wangrunji0408 wangrunji0408 merged commit 7e7ac93 into rcore-os:master Jun 29, 2020
@equation314 equation314 deleted the fix branch July 1, 2020 17:08
@benpigchu benpigchu mentioned this pull request Jul 2, 2020
1 task
@wangrunji0408 wangrunji0408 added the bug Something isn't working label Jul 7, 2020
zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
Fix bugs when run Fuchsia 20200628
@coveralls
Copy link

coveralls commented Jul 14, 2024

Pull Request Test Coverage Report for Build 151504134

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 30 (3.33%) changed or added relevant lines in 4 files are covered.
  • 55 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.07%) to 22.696%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zircon-syscall/src/task.rs 0 1 0.0%
zircon-object/src/task/job.rs 0 3 0.0%
zircon-syscall/src/time.rs 0 6 0.0%
zircon-object/src/task/process.rs 1 20 5.0%
Files with Coverage Reduction New Missed Lines %
zircon-object/src/object/mod.rs 1 75.13%
zircon-syscall/src/time.rs 1 0.0%
zircon-object/src/task/job.rs 2 57.14%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/hashbrown-0.7.2/src/raw/mod.rs 4 45.96%
zircon-object/src/task/process.rs 47 32.74%
Totals Coverage Status
Change from base Build 150314444: -0.07%
Covered Lines: 2069
Relevant Lines: 9116

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants