Cmake #654
Cmake #654
Conversation
Cmake release
There was a problem hiding this comment.
LGTM, nitpicks on commented code. This looks like a good upgrade from the current Make based build system. One question, does this handle rebuilding targets when a header file dependency changes? It wasn't clear to me that it does unless cmake handles it automatically when you specify includes.
CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| set(CMAKE_CXX_FLAGS "-std=c++11 -Wall -fPIC -Werror") | ||
| #CXXFLAGS = -std=c++11 -Wall -fPIC -Werror -ferror-limit=5 |
There was a problem hiding this comment.
Do we need this comment?
src/CMakeLists.txt
Outdated
| ) | ||
|
|
||
|
|
||
| #TARGETS coreir coreirsim coreir-commonlib |
There was a problem hiding this comment.
Do we need this comment?
| COMMENT "Copying to lib/" | ||
| ) | ||
|
|
||
| endforeach() |
There was a problem hiding this comment.
foreach is a nice feature
|
I think it's okay to merge this before tests have been migrated, since this seems like it will make it easier to work with the build system. |
|
@leonardt, it does seem to incrementally rebuild appropriately when I edit some .h files. |
This PR is Cmakeifying CoreIR.
Tests are not being done using cmake currently.
A large chunk of the files changed are due to fixing warnings when building the release version of cmake. These are fixed by changing assert -> ASSERT and by using a new coreir_unreachable() macro.