Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MsgPack deprecation #128

Merged
merged 6 commits into from
Oct 12, 2019
Merged

Fix MsgPack deprecation #128

merged 6 commits into from
Oct 12, 2019

Conversation

rdeits
Copy link
Owner

@rdeits rdeits commented Oct 11, 2019

On top of #126

@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   79.21%   79.21%           
=======================================
  Files          15       15           
  Lines         457      457           
=======================================
  Hits          362      362           
  Misses         95       95
Impacted Files Coverage Δ
src/MeshCat.jl 30.43% <ø> (ø) ⬆️
src/msgpack.jl 16.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cdec1...98b58f9. Read the comment docs.

@rdeits rdeits merged commit a038dc2 into master Oct 12, 2019
@rdeits rdeits deleted the rd/msgpack-update branch October 12, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants