Issue warning about minimum supported N++ version

Author: Robert Di Pardo

README.textile

@@ -22,6 +22,17 @@ It originated in these requests on the Plugin Development forum on SourceForge.n
 
 h2. Installation
 
+===============================================================================================
+
+h3. _Warning_
+
+_*Always* check your Notepad++ version at "? > Debug Info" before installing plugins_
+_Notepad++ 8.3 is the *minimum required* version for 64-bit releases of HTML Tag 1.2 and newer_
+
+You can safely use any 32-bit version of HTML Tag with any 32-bit version of Notepad++
+
+===============================================================================================
+
 As usual:
 Extract the DLL and accompanying files to the plugins folder under
 @%ProgramFiles%\Notepad++@ (or wherever you're running Notepad++ from) or @%AppData%\Notepad++@, and (re)start Np++.
@@ -57,8 +68,8 @@ _Up to version 1.1.0, plugin release bundles include all of the following:_
 h2. History
 
 * 1.1.0 - 2017-09-04 20:15
-** Added: option to encode line break entities as well [689eef6cee]
-** Fixed: decoding a JS escape reduced the selection by one each time [e717ed1de5]
+** Added: option to encode line break entities as well "[689eef6cee]":689eef6cee
+** Fixed: decoding a JS escape reduced the selection by one each time "[e717ed1de5]":e717ed1de5
 * 1.0.0 - 2017-02-19 16:03
 ** Added: 64-bit version
 ** Several tiny bugfixes
@@ -92,12 +103,18 @@ h2. History
 
 h3. To do
 
-* [Request#1848503] Add a command to close the open tag at the current location
+* "[Request#1848503]":1848503 Add a command to close the open tag at the current location
 * Add command to encode entities in the contents only (only apply encoding when not inside tags;
   leave valid tags and entities alone)
 * Add command to select tags only (and leave the contents out of the selection)
 * Make it play nice(r) with PHP & ASP tags (either highlight those separately or ignore them)
 * Add option to encode entities 'as-you-type'
 * Add option to close tags 'as-you-type' (type '</' and the rest will be inserted automagically)
-* [Request#2147949] drop down a list of tags after '<'
-* [Request#2147949] drop down a list of attributes on space after a tag
+* "[Request#2147949]":2147949 drop down a list of tags after '<'
+* "[Request#2147949]":2147949 drop down a list of attributes on space after a tag
+
+
+[689eef6cee]https://fossil.2of4.net/npp_htmltag/info/689eef6cee
+[e717ed1de5]https://fossil.2of4.net/npp_htmltag/info/e717ed1de5
+[1848503]https://fossil.2of4.net/npp_htmltag/tktview?name=a3fc2e7864
+[2147949]https://fossil.2of4.net/npp_htmltag/tktview?name=43695affda

src/U_Npp_HTMLTag.pas

@@ -6,14 +6,18 @@ interface
 uses
   SysUtils, Windows,
   NppPlugin, SciSupport,
-  NppSimpleObjects;
+  NppSimpleObjects, L_VersionInfoW;
 
 type
   TNppPluginHTMLTag = class(TNppPlugin)
   private
     FApp: TApplication;
+    FVersionInfo: TFileVersionInfo;
+    FVersionStr: nppString;
+    function SupportsBigFiles: Boolean;
   public
     constructor Create;
+    destructor Destroy; override;
     procedure commandFindMatchingTag;
     procedure commandSelectTagContents;
     procedure commandSelectTagContentsOnly;
@@ -46,9 +50,9 @@ procedure _commandAbout(); cdecl;
 implementation
 
 uses
-  DateUtils,
+  Strutils,
   ShellAPI,
-  L_VersionInfoW, L_SpecialFolders,
+  L_SpecialFolders,
   U_HTMLTagFinder, U_Entities, U_JSEncode;
 
 { ------------------------------------------------------------------------------------------------ }
@@ -152,13 +156,51 @@ constructor TNppPluginHTMLTag.Create;
   self.AddFuncSeparator;
 
   self.AddFuncItem('&About...', _commandAbout);
+
+  try
+     FVersionInfo := TFileVersionInfo.Create(TSpecialFolders.DLLFullName);
+     FVersionStr := ChangeFileExt(ExtractFileName(TSpecialFolders.DLLFullName), '');
+     FVersionStr :=
+      Concat(FVersionStr,
+        Format(' %d.%d.%d (%s bit)',
+          [FVersionInfo.MajorVersion, FVersionInfo.MinorVersion, FVersionInfo.Revision,
+          {$IFDEF CPUX64}'64'{$ELSE}'32'{$ENDIF}]));
+  except
+    FreeAndNil(FVersionInfo);
+  end;
+
+{$IFNDEF CPUX64}
+  FVersionStr := ReplaceStr(FVersionStr, '_unicode', '');
+{$ENDIF}
+end;
+
+{ ------------------------------------------------------------------------------------------------ }
+destructor TNppPluginHTMLTag.Destroy;
+begin
+  if Assigned(FVersionInfo) then
+    FreeAndNil(FVersionInfo);
+  inherited;
 end;
 
 { ------------------------------------------------------------------------------------------------ }
 procedure TNppPluginHTMLTag.DoNppnToolbarModification;
+var
+  Msg: string;
 begin
   inherited;
   FApp := GetApplication(@Self.NppData);
+
+{$IFDEF CPUX64}
+  try
+    if not SupportsBigFiles then begin
+      Msg := 'The installed version of HTML Tag requires Notepad++ 8.3 or newer.'#13#10
+             + 'Running any plugin command will crash the application!';
+      MessageBox(App.WindowHandle, PChar(Msg), PChar(FVersionStr), MB_ICONWARNING);
+    end;
+  except
+    HandleException(ExceptObject, ExceptAddr);
+  end;
+{$ENDIF}
 end;
 
 { ------------------------------------------------------------------------------------------------ }
@@ -253,40 +295,50 @@ procedure TNppPluginHTMLTag.commandDecodeJS;
 { ------------------------------------------------------------------------------------------------ }
 procedure TNppPluginHTMLTag.commandAbout;
 var
-  Version: TFileVersionInfo;
   Text, DLLName: string;
 begin
   try
     DLLName := TSpecialFolders.DLLFullName;
-    Version := TFileVersionInfo.Create(DLLName);
-    try
-      Text := Format('%s v%s %s'#10#10
+    if not Assigned(FVersionInfo) then begin
+      FVersionInfo := TFileVersionInfo.Create(DLLName);
+    end;
+
+    Text := Format('%s'#10#10
                       + 'Plug-in location: %s'#10
                       + 'Config location: %s'#10
                       + 'Bugs: %s'#10
                       + 'Download: %s'#10#10
                       + #$00A9' 2011-2020 %s - %s'#10
                       + '  a.k.a. %s - %s (v0.1 - v1.1)'#10
-                      + #$00A9' 2022 Robert Di Pardo (v1.2 -)'#10#10
+                      + #$00A9' 2022 Robert Di Pardo (since v1.2)'#10#10
                       + 'Licensed under the %s - %s',
-                     [ExtractFileName(DLLName), Version.FileVersion,
-                      {$IFDEF WIN64}'(64-bits)'{$ELSE}'(32-bits)'{$ENDIF},
-                      ExtractFilePath(DLLName),
+                     [FVersionStr,
+                      ExtractFileDir(DLLName),
                       App.ConfigFolder,
-                      Version.Comments,
+                      FVersionInfo.Comments,
                       'https://bitbucket.org/rdipardo/htmltag/downloads',
-                      Version.LegalCopyright, 'http://fossil.2of4.net/npp_htmltag', // 'http://martijn.coppoolse.com/software',
+                      FVersionInfo.LegalCopyright, 'http://fossil.2of4.net/npp_htmltag', // 'http://martijn.coppoolse.com/software',
                       'vor0nwe', 'http://sourceforge.net/users/vor0nwe',
                       'MPL 1.1', 'http://www.mozilla.org/MPL/1.1']);
-      MessageBox(App.WindowHandle, PChar(Text), PChar(Version.FileDescription), MB_ICONINFORMATION)
-    finally
-      FreeAndNil(Version);
-    end;
+    MessageBox(App.WindowHandle, PChar(Text), PChar(FVersionInfo.FileDescription), MB_ICONINFORMATION)
   except
     HandleException(ExceptObject, ExceptAddr);
   end;
 end {TNppPluginHTMLTag.commandAbout};
 
+{ ------------------------------------------------------------------------------------------------ }
+function TNppPluginHTMLTag.SupportsBigFiles: Boolean;
+var
+  NppVerison: Cardinal;
+begin
+  NppVerison := FApp.SendMessage(NPPM_GETNPPVERSION);
+  Result :=
+    (HIWORD(NppVerison) > 8) or
+    ((HIWORD(NppVerison) = 8) and
+      // 8.3 -> 8,3 (*not* 8,30)
+      ((LOWORD(NppVerison) = 3) or (LOWORD(NppVerison) > 21)));
+end {TNppPluginHTMLTag.SupportsBigFiles};
+