Remove calls to obsolete style byte APIs

Per https://www.scintilla.org/ScintillaDoc.html#SCI_GETSTYLEBITS

> The last [Scintilla] version to support style byte indicators was 3.4.2.
> Any use of these symbols should be removed and replaced with standard
> indicators: https://www.scintilla.org/ScintillaDoc.html#Indicators

Author: Robert Di Pardo

src/LibNppPlugin/NppSimpleObjects.pas

@@ -58,7 +58,7 @@     TTextRange = class
 
         procedure Select();
         procedure Indent(const Levels: integer = 1);
-        procedure Mark(const Style: integer; const Mask: integer = 0; const DurationInMs: cardinal = 0);
+        procedure Mark(const Style: integer; const DurationInMs: cardinal = 0);
 
         property Document: TActiveDocument  read FEditor;
         property StartPos: Sci_Position     read FStartPos        write SetStart;
@@ -451,30 +451,14 @@ procedure TTextRange.Indent(const Levels: integer);
 
 { ------------------------------------------------------------------------------------------------ }
 
-procedure TTextRange.Mark(const Style, Mask: integer; const DurationInMs: cardinal);
+procedure TTextRange.Mark(const Style: integer; const DurationInMs: cardinal);
 var
   CurrentStyleEnd: Sci_Position;
-  StyleBits: integer;
 begin
   CurrentStyleEnd := FEditor.SendMessage(SCI_GETENDSTYLED);
-  {
-    Per https://www.scintilla.org/ScintillaDoc.html#SCI_GETSTYLEBITS:
-
-    "The following are features that should be removed from calling code but are
-    still defined to avoid breaking callers.
-
-    "Scintilla no longer supports style byte indicators. The last version to
-    support style byte indicators was 3.4.2. Any use of these symbols should be
-    removed and replaced with standard indicators <https://www.scintilla.org/ScintillaDoc.html#Indicators>"
-  }
-  StyleBits := FEditor.SendMessage(SCI_GETSTYLEBITS);
-  if Mask = 0 then begin
-    FEditor.SendMessage(SCI_STARTSTYLING, FStartPos, StyleBits);
-  end else begin
-    FEditor.SendMessage(SCI_STARTSTYLING, FStartPos, Mask);
-  end;
+  FEditor.SendMessage(SCI_STARTSTYLING, FStartPos, 0);
   FEditor.SendMessage(SCI_SETSTYLING, GetLength, Style);
-  FEditor.SendMessage(SCI_STARTSTYLING, CurrentStyleEnd, StyleBits);
+  FEditor.SendMessage(SCI_STARTSTYLING, CurrentStyleEnd, 0);
 
   if DurationInMs > 0 then
     TimedTextRangeMarks.Add(TTextRangeMark.Create(Self, DurationInMs));
@@ -1103,7 +1087,7 @@ destructor TTextRangeMark.Destroy;
       CurrentStyleEnd := Editor.SendMessage(SCI_GETENDSTYLED);
       if FStartPos < CurrentStyleEnd then
         CurrentStyleEnd := FStartPos;
-      Editor.SendMessage(SCI_STARTSTYLING, CurrentStyleEnd, Editor.SendMessage(SCI_GETSTYLEBITS));
+      Editor.SendMessage(SCI_STARTSTYLING, CurrentStyleEnd, 0);
     except
       on E: Exception do begin
         // ignore

src/U_HTMLTagFinder.pas

@@ -338,22 +338,12 @@ procedure FindMatchingTag(ASelect: boolean = False; AContentsOnly: Boolean = Fal
             end;
           end else begin
             MatchingTag.Select;
-            {$IFNDEF NPPUNICODE} // NPP Unicode has always done this itself
-            if HIWORD(npp.SendMessage(NPPM_GETNPPVERSION)) < 5 then begin
-              Tag.Mark(STYLE_BRACELIGHT, 255, ncHighlightTimeout);
-              MatchingTag.Mark(STYLE_BRACELIGHT, 255, ncHighlightTimeout);
-            end;
-            {$ENDIF}
           end;
         end else begin
           if ASelect then begin
             MatchingTag.Select;
           end else begin
             MatchingTag.Select;
-            {$IFNDEF NPPUNICODE} // NPP Unicode has always done this itself
-            if HIWORD(npp.SendMessage(NPPM_GETNPPVERSION)) < 5 then
-              MatchingTag.Mark(STYLE_BRACELIGHT, 255, ncHighlightTimeout);
-            {$ENDIF}
           end;
         end;
       end else if Tags.Count > 0 then begin
@@ -362,7 +352,7 @@ procedure FindMatchingTag(ASelect: boolean = False; AContentsOnly: Boolean = Fal
         if ASelect then begin
           Tag.Select;
         end;
-        Tag.Mark(STYLE_BRACEBAD, 255, ncHighlightTimeout);
+        Tag.Mark(STYLE_BRACEBAD, ncHighlightTimeout);
       end else begin
         MessageBeep(MB_ICONWARNING);
       end;

src/prj/HTMLTag.lpi

@@ -71,7 +71,6 @@
             <CustomOptions Value="-dUNICODE
 -dNPPUNICODE
 -dSCI_DISABLE_PROVISIONAL
--dINCLUDE_DEPRECATED_FEATURES
 -FcUTF8
 -vm2026,4104,5024"/>
             <OtherDefines Count="2">
@@ -181,7 +180,6 @@
 -dNPPUNICODE
 -FcUTF8
 -dSCI_DISABLE_PROVISIONAL
--dINCLUDE_DEPRECATED_FEATURES
 -WN
 -vm2026"/>
     </Other>