Extract version check to plugin base class

Also takes advantage of padded low words, implemented in v8.4.1

Cf. notepad-plus-plus/notepad-plus-plus@ef609c8

Author: Robert Di Pardo

src/LibNppPlugin/nppplugin.pas

@@ -36,6 +36,8 @@   TNppPlugin = class(TObject)
     FConfigDir: string;
   protected
     PluginName: nppString;
+    function SupportsBigFiles: Boolean;
+    function GetNppVersion: Cardinal;
     function GetPluginsConfigDir: string;
     function AddFuncSeparator: Integer;
     function AddFuncItem(Name: nppString; Func: PFUNCPLUGINCMD): Integer; overload;
@@ -350,4 +352,34 @@ function TNppPlugin.CmdIdFromDlgId(DlgId: Integer): Integer;
   Result := self.FuncArray[DlgId].CmdId;
 end;
 
+function TNppPlugin.GetNppVersion: Cardinal;
+var
+  NppVersion: Cardinal;
+begin
+  NppVersion := SendMessage(self.NppData.NppHandle, NPPM_GETNPPVERSION, 0, 0);
+  // retrieve the zero-padded version, if available
+  // https://github.com/notepad-plus-plus/notepad-plus-plus/commit/ef609c896f209ecffd8130c3e3327ca8a8157e72
+  if ((HIWORD(NppVersion) > 8) or
+      ((HIWORD(NppVersion) = 8) and
+        (((LOWORD(NppVersion) >= 41) and (not (LOWORD(NppVersion) in [191, 192, 193]))) or
+          (LOWORD(NppVersion) in [5, 6, 7, 8, 9])))) then
+    NppVersion := SendMessage(self.NppData.NppHandle, NPPM_GETNPPVERSION, 1, 0);
+
+  Result := NppVersion;
+end;
+
+function TNppPlugin.SupportsBigFiles: Boolean;
+var
+  NppVersion: Cardinal;
+begin
+  NppVersion := GetNppVersion;
+  Result :=
+    (HIWORD(NppVersion) > 8) or
+    ((HIWORD(NppVersion) = 8) and
+      // 8.3 => 8,3 *not* 8,30
+      ((LOWORD(NppVersion) in [3, 4]) or
+       // Also check for N++ versions 8.1.9.1, 8.1.9.2 and 8.1.9.3
+       ((LOWORD(NppVersion) > 21) and (not (LOWORD(NppVersion) in [191, 192, 193])))));
+end;
+
 end.

src/U_Npp_HTMLTag.pas

@@ -16,7 +16,6 @@   TNppPluginHTMLTag = class(TNppPlugin)
     FApp: TApplication;
     FVersionInfo: TFileVersionInfo;
     FVersionStr: nppString;
-    function SupportsBigFiles: Boolean;
   public
     constructor Create;
     destructor Destroy; override;
@@ -356,30 +355,6 @@ procedure TNppPluginHTMLTag.commandAbout;
 end {TNppPluginHTMLTag.commandAbout};
 
 { ------------------------------------------------------------------------------------------------ }
-function TNppPluginHTMLTag.SupportsBigFiles: Boolean;
-const
-  PatchReleases: Array[0..2] of Word = ( 191, 192, 193 );
-var
-  NppVersion: Cardinal;
-  IsPatchRelease: Boolean;
-  i: Byte;
-begin
-  NppVersion := FApp.SendMessage(NPPM_GETNPPVERSION);
-  IsPatchRelease := False;
-
-  for i := 0 to Length(PatchReleases) - 1 do
-  begin
-    IsPatchRelease := (LOWORD(NppVersion) = PatchReleases[i]);
-    if IsPatchRelease then Break;
-  end;
-
-  Result :=
-    (HIWORD(NppVersion) > 8) or
-    ((HIWORD(NppVersion) = 8) and
-      // 8.3 -> 8,3 (*not* 8,30)
-      (((LOWORD(NppVersion) >= 3) and (LOWORD(NppVersion) <= 9)) or
-       ((LOWORD(NppVersion) > 21) and not IsPatchRelease)))
-end {TNppPluginHTMLTag.SupportsBigFiles};