Skip to content

Add Serbian (Cyrillic & Latin) translations#14

Merged
rdipardo merged 5 commits intordipardo:defaultfrom
rammba:features/serbian-2025-09-19
Sep 25, 2025
Merged

Add Serbian (Cyrillic & Latin) translations#14
rdipardo merged 5 commits intordipardo:defaultfrom
rammba:features/serbian-2025-09-19

Conversation

@rammba
Copy link
Copy Markdown

@rammba rammba commented Sep 19, 2025

Hello @rdipardo, thanks for making this plugin.
Please tell me if this is a wrong platform for PR, because this is the clone of bitbucket repo.

I'm actively translating N++ to Serbian, and I found out that your plugin also supports different languages, so I decided to add Serbian here as well. Besides N++, I'm also translating official React documentation to Serbian and few other open-source projects.

I have few suggestions regarding translation process.
First of all, it's hard to find english version of labels without explicit file, even though I'm not just a translator, but a developer also. It would be great to have english labels on one place that's not .h, .cpp, or some other non-translation file.
Second thing, I've tried to find english label for err_config_msg, but didn't succeed. Apperantly, it's added in this commit. Can you please provide english label in order to translate it properly?

I hope you will accept Serbian languages for your plugin. Thanks for the response in advance 🚀

Comment thread dat/HTMLTag-translations.ini Outdated
@rdipardo rdipardo added enhancement New feature or request i18n Adds or updates a localization labels Sep 20, 2025
@rdipardo
Copy link
Copy Markdown
Owner

Thanks for the PR and suggestions.

I've written up a guide for translators. The default English strings you mentioned are still hard-coded for now. The whole approach to error message localization should probably be replaced with something more straightforward.

Dialog translations are another rough spot. Whereas the menu picks up a new language just by reading the INI file, the About dialog needs additional coding, as explained in the guide.

If you have the patience for Windows resource scripts, it would be great if you could add them to this PR. If not, I'll make sure to add them before a new release.

You may also want to see if other localized Notepad++ plugins need a Serbian translation, for example:

@rammba
Copy link
Copy Markdown
Author

rammba commented Sep 21, 2025

Hello @rdipardo, thanks for the response and explanation. I think I've added all the things listed in the guide, so please check it.

If you have the patience for Windows resource scripts, it would be great if you could add them to this PR

Sorry, I don't have time for the coding currently. I just want to finish some translations I've planned.

You may also want to see if other localized Notepad++ plugins need a Serbian translation

Thanks for the notice, I've also seen those and planned to do a translation there as well.

I've written up a guide for translators.

I think you gave an example for RTL languages in the guide because WS_EX_RTLREADING is mentioned there, so I've copied content from Russian file, because they also use cyrillic as Serbian.

rdipardo pushed a commit that referenced this pull request Sep 25, 2025
 * Translate HTMLTag-translations.ini to Serbian

 * Translate HTMLTag-dialogs.ini to Serbian

 * Translate missing err_config_msg label

 * Translate dialog captions

 * Add Serbian .rc files
@rdipardo rdipardo added this to the v1.5.5 milestone Sep 25, 2025
@rdipardo
Copy link
Copy Markdown
Owner

rdipardo commented Sep 25, 2025

Looks good, thanks.

Since the master repo is still on Bitbucket — and GitHub doesn't provide proper mirrors anymore — I have to push your changes to Bitbucket, which will then mirror them back here. Hopefully the PR status will change accordingly. If not, don't worry if GH thinks the PR was "closed" without merging 😉

@rdipardo rdipardo merged commit 4acb37c into rdipardo:default Sep 25, 2025
1 check passed
@rammba rammba deleted the features/serbian-2025-09-19 branch September 25, 2025 19:54
@rammba
Copy link
Copy Markdown
Author

rammba commented Sep 25, 2025

Looks like changes and PR are successfully merged. I'm looking forward to see it live soon 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request i18n Adds or updates a localization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants