Skip to content

Move code to RDKCentral#1

Merged
TeknoVenus merged 3 commits intordkcentral:mainfrom
TeknoVenus:initial-changes
Aug 18, 2023
Merged

Move code to RDKCentral#1
TeknoVenus merged 3 commits intordkcentral:mainfrom
TeknoVenus:initial-changes

Conversation

@TeknoVenus
Copy link
Copy Markdown
Contributor

@TeknoVenus TeknoVenus commented Aug 2, 2023

Move code from https://github.com/TeknoVenus/MemCapture to RDKCentral

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 2, 2023

Copyright scan failure

Commit: 129fcc4
Report detail: https://gist.github.com/rdkcmf-jenkins/028f35ca91038ee7190d116d1a0f245f

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 2, 2023

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 33 files pending identification.

  • Protex Server Path: /home/blackduck/github/MemCapture/1/rdkcentral/MemCapture

  • Commit: 129fcc4

Report detail: gist

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 2, 2023

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 33 files pending identification.

  • Protex Server Path: /home/blackduck/github/MemCapture/1/rdkcentral/MemCapture

  • Commit: 129fcc4

Report detail: gist

@mhughesacn
Copy link
Copy Markdown

mhughesacn commented Aug 3, 2023

Hi Stephen:

Some comments please.

  • Can the 3rd party packages be fetched not hosted, especially json.hpp which is bigger than the rest of the repo (900 vs. 500kB)?

  • Missing NOTICE file. Copyright 2023 Stephen Foulds with extra credits (depending on what 3rd party code remains). (Inja is MIT licensed & Copyright Lars Berscheid; json is MIT licensed & Copyright Neils Lohmann (et al) except for code from The Abseil Authors (Apache-2.0); incbin is licensed under the Unlicense & author Dale Weiler (but not a copyright).

  • LICENSE will need a copy of the Unlicense if incbin remains.

  • MemoryMetric.cpp: Is everything in this file suitable for opensourcing? There is material in the file about memory information for different SOCs, and how to get it. (This may be OK as the corresponding kernels will be linux-flavoured and therefore GPL.)

Thank you.

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 17, 2023

Copyright scan failure

Commit: d00c103
Report detail: https://gist.github.com/rdkcmf-jenkins/0629700648165df7c3a8e73b68c91c2d

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 17, 2023

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 33 files pending identification.

  • Protex Server Path: /home/blackduck/github/MemCapture/1/rdkcentral/MemCapture

  • Commit: d00c103

Report detail: gist

@TeknoVenus
Copy link
Copy Markdown
Contributor Author

TeknoVenus commented Aug 17, 2023

@mhughesacn I've made the following changes:

  • License is now 2023 Sky UK rather than me personally
  • Removed json.hpp and inja.hpp from the repo (kept incbin as that's not readily available in any package manager and it's very small)
  • Added NOTICE file and updated LICENSE file

Regarding the MemoryMetric file, that is fine for open sourcing since, as you say, it's using standard kernel interfaces/metrics and the kernels themselves are GPL

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 17, 2023

Copyright scan failure

Commit: 833ad7d
Report detail: https://gist.github.com/rdkcmf-jenkins/6f4634e524a4746f7fd9eb57c3932781

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 17, 2023

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 33 files pending identification.

  • Protex Server Path: /home/blackduck/github/MemCapture/1/rdkcentral/MemCapture

  • Commit: 833ad7d

Report detail: gist

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 17, 2023

Copyright scan failure

Commit: cff3371
Report detail: https://gist.github.com/rdkcmf-jenkins/e61cf78051479b672ce18e3da6337cc0

Improve JSON format (RDK-43464)
b8a6bc0 
Update license information
Remove 3rd party packages - use vcpkg for desktop builds

Signed-off-by: Stephen Foulds <stephen.foulds@consult.red>
@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 17, 2023

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 31 files pending identification.

  • Protex Server Path: /home/blackduck/github/MemCapture/1/rdkcentral/MemCapture

  • Commit: cff3371

Report detail: gist

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 17, 2023

Copyright scan failure

Commit: b8a6bc0
Report detail: https://gist.github.com/rdkcmf-jenkins/6c41608d1df02cb8391eec76229f39af

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 17, 2023

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 31 files pending identification.

  • Protex Server Path: /home/blackduck/github/MemCapture/1/rdkcentral/MemCapture

  • Commit: b8a6bc0

Report detail: gist

mhughesacn
mhughesacn reviewed Aug 17, 2023
View reviewed changes
Comment thread LICENSE
@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 17, 2023

Blackduck scan failure details

Summary: 0 violations, 1 file pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/MemCapture/1/rdkcentral/MemCapture

  • Commit: 8135270

Report detail: gist

@rdkcmf-jenkins
Copy link
Copy Markdown
Contributor

rdkcmf-jenkins commented Aug 17, 2023

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: Many thanks!

  • Commit: 8135270

@TeknoVenus TeknoVenus merged commit 4487bed into rdkcentral:main Aug 18, 2023
@TeknoVenus TeknoVenus deleted the initial-changes branch August 18, 2023 10:22
TeknoVenus pushed a commit to TeknoVenus/MemCaptureRDK that referenced this pull request Nov 16, 2023
Merge pull request rdkcentral#1 from TeknoVenus/xione_brcm
d085a64 
Xione (Broadcom) platform - Added CMA and GPU memory metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhughesacn mhughesacn mhughesacn left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TeknoVenus @rdkcmf-jenkins @mhughesacn