Skip to content

RDKEMW-14121 : Added Mediatek Platform support in Memcapture Code Base#13

Merged
nhanasi merged 5 commits intordkcentral:mainfrom
tabbas651:main
Mar 26, 2026
Merged

RDKEMW-14121 : Added Mediatek Platform support in Memcapture Code Base#13
nhanasi merged 5 commits intordkcentral:mainfrom
tabbas651:main

Conversation

@tabbas651
Copy link
Copy Markdown
Contributor

Reason for change: Added MEDIATEK Platform support
Test Procedure: please refer the ticket comments
Risks: Medium

Copilot AI review requested due to automatic review settings March 2, 2026 19:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new MEDIATEK platform option to MemCapture so the tool can be invoked/configured for MediaTek-based devices.

Changes:

  • Extend CLI help text and argument parsing to accept --platform MEDIATEK.
  • Add Platform::MEDIATEK to the platform enum.
  • Add initial MEDIATEK handling in MemoryMetric (memory bandwidth condition and fragmentation column count).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
main.cpp Adds MEDIATEK to usage text and parses --platform MEDIATEK into Platform::MEDIATEK.
Platform.h Extends the Platform enum with MEDIATEK.
MemoryMetric.cpp Attempts to include MEDIATEK in some platform-specific metric logic (bandwidth/fragmentation).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Platform.h
Comment thread MemoryMetric.cpp Outdated
Comment thread MemoryMetric.cpp Outdated
Comment thread MemoryMetric.cpp
Reason for change: Added MEDIATEK Platform support
Test Procedure: please refer the ticket comments
Risks: Medium
Signed-off-by: Thamim Razith Abbas Ali <tabbas651@cable.comcast.com>
Copilot AI review requested due to automatic review settings March 2, 2026 21:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread MemoryMetric.h Outdated
Comment thread MemoryMetric.cpp
Comment thread MemoryMetric.cpp Outdated
meditek platform and  added cma regions map and added getmemorybandwidth
should be false in meditek
Copilot AI review requested due to automatic review settings March 5, 2026 16:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

@nhanasi nhanasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please raise review from feature branch to make official release as this method lands the code in the main branch

Copilot AI review requested due to automatic review settings March 24, 2026 16:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nhanasi nhanasi merged commit 76faed0 into rdkcentral:main Mar 26, 2026
4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants