Skip to content

RDKBWIFI-445: Fixed binary data comparison in webconfig #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vlad-safonov wants to merge 2 commits into
base: develop
Choose a base branch
from
+4 −5
Open

RDKBWIFI-445: Fixed binary data comparison in webconfig #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22c9b19
Fixed binary data comparison in webconfig
vlad-safonov May 21, 2026
dd1e99e
fixed bbackhaul_bss_config_policy.bssid mac copy in wifi_decoder
vlad-safonov Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/webconfig_external_proto_easymesh.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ typedef void (*ext_proto_update_ap_mld_info_t)(void *data_model, em_ap_mld_info_
typedef void (*ext_proto_update_bsta_mld_info_t)(void *data_model, em_bsta_mld_info_t *bsta_mld_info);
typedef void (*ext_proto_update_assoc_sta_mld_info_t)(void *data_model, em_assoc_sta_mld_info_t *assoc_sta_mld_info);
typedef em_ap_mld_info_t * (*ext_proto_get_ap_mld_frm_bssid_t)(void *data_model, mac_address_t bss_id);
typedef em_radio_cap_info_t * (*ext_proto_get_radio_cap_t)(void *data_model, int index);
typedef em_radio_cap_info_t * (*ext_proto_get_radio_cap_t)(void *data_model, unsigned int index);
Copy link
Copy Markdown
Contributor Author

@vlad-safonov vlad-safonov May 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nikita-Hakai , I would like to discuss this line - if we do it - it also requires some adjustments in unified-wifi-mesh, something like

diff --git a/inc/dm_easy_mesh.h b/inc/dm_easy_mesh.h
index bac8a20..aa2c217 100644
--- a/inc/dm_easy_mesh.h
+++ b/inc/dm_easy_mesh.h
@@ -1738,8 +1738,8 @@ public:
        void update_assoc_sta_mld_info(em_assoc_sta_mld_info_t *assoc_sta_mld_info);
        static void update_assoc_sta_mld_info(void *dm, em_assoc_sta_mld_info_t *assoc_sta_mld_info) { (static_cast<dm_easy_mesh_t *>(dm))->update_assoc_sta
_mld_info(assoc_sta_mld_info); }

-       em_radio_cap_info_t *get_radio_cap_info(int index);
-       static em_radio_cap_info_t *get_radio_cap_info(void *dm, int index) { return (static_cast<dm_easy_mesh_t *>(dm))->get_radio_cap_info(index); }
+       em_radio_cap_info_t *get_radio_cap_info(unsigned int index);
+       static em_radio_cap_info_t *get_radio_cap_info(void *dm, unsigned int index) { return (static_cast<dm_easy_mesh_t *>(dm))->get_radio_cap_info(index)
; }

        /**!
         * @brief Retrieves the Data Model DPP object.

and remove some castings which will make code cleaner, so do you want to have this fix here and merge it together with unified-wifi-mesh?

Copy link
Copy Markdown
Contributor

@Nikita-Hakai Nikita-Hakai Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @vlad-safonov, sorry caught to this notification little late. I see that corresponding unified-wifi-mesh changes are raised, will have to merge it together. Can you kindly confirm, if the changes are good in the sense not breaking working functionality?

Copy link
Copy Markdown
Contributor Author

@vlad-safonov vlad-safonov Jun 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nikita-Hakai yes from my point of view it is safe, we performed tests and there are no regressions


typedef struct {
void *data_model; /* agent data model dm_easy_mesh_t */
Expand Down
3 changes: 1 addition & 2 deletions source/webconfig/wifi_decoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6441,8 +6441,7 @@ webconfig_error_t decode_em_policy_object(const cJSON *em_cfg, em_config_t *em_c
}

decode_param_allow_optional_string(backhaul_policy, "BSSID", param);
strncpy((char *)em_config->backhaul_bss_config_policy.bssid, param->valuestring,
sizeof(bssid_t));
str_to_mac_bytes(param->valuestring, em_config->backhaul_bss_config_policy.bssid);

decode_param_allow_optional_string(backhaul_policy, "Profile-1 bSTA Disallowed", param);
em_config->backhaul_bss_config_policy.profile_1_bsta_disallowed = 0; // param->valuedouble;
Expand Down
2 changes: 1 addition & 1 deletion source/webconfig/wifi_easymesh_translator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1589,7 +1589,7 @@ webconfig_error_t translate_ap_metrics_report_to_easy_mesh_bss_info(webconfig_su
int found = 0;
for (int k = 0; k < MAX_NUM_VAP_PER_RADIO; k++) {
ap_metrics = &em_ap_report->radio_reports[i].vap_reports[k];
if (strncmp(ap_metrics->vap_metrics.bssid, vap->u.bss_info.bssid, sizeof(bssid_t)) == 0) {
if (memcmp(ap_metrics->vap_metrics.bssid, vap->u.bss_info.bssid, sizeof(bssid_t)) == 0) {
found = 1;
break;
}
Expand Down
2 changes: 1 addition & 1 deletion source/webconfig/wifi_encoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3459,7 +3459,7 @@ webconfig_error_t encode_em_ap_metrics_report_object(rdk_wifi_radio_t *radio,
vap_arr_index = -1;
for (int k = 0; k < MAX_NUM_VAP_PER_RADIO; k++) {
ap_metrics = &radio_report->vap_reports[k];
if (strncmp(vap->u.bss_info.bssid, ap_metrics->vap_metrics.bssid,
if (memcmp(vap->u.bss_info.bssid, ap_metrics->vap_metrics.bssid,
sizeof(bssid_t)) == 0) {
vap_arr_index = k;
break;
Expand Down
Loading