RDKEMW-10311 : RF4CE update key mapping #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements RF4CE key mapping updates related to push-to-talk functionality, adding synthetic key event generation for voice sessions and updating key-to-Linux mappings.
- Adds synthetic key down/up events for push-to-talk voice sessions to properly track voice button state
- Updates INFO key mapping from KEY_F9 to KEY_F20 and removes associated modifiers
- Adds new PUSH_TO_TALK key mapping to KEY_F8
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/rf4ce/ctrlm_rf4ce_network.cpp | Adds logic to send synthetic KEY_DOWN/KEY_UP events for CTRLM_KEY_CODE_PUSH_TO_TALK during voice session lifecycle (request, rejection, and stop) |
| src/input_event/ctrlm_input_event_writer.h | Updates INFO key mapping from KEY_F9 to KEY_F20 and adds new PUSH_TO_TALK mapping to KEY_F8 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
egalla204
approved these changes
Nov 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.