Skip to content

RDKEMW-10336 - Update GetWiFiSignalQuality to use SIGNAL_POLL #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karuna2git merged 7 commits into from
Nov 13, 2025
Merged

RDKEMW-10336 - Update GetWiFiSignalQuality to use SIGNAL_POLL #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7c6a316
Initial code change
cmuhammedrafi Nov 13, 2025
baec2a8
fixing the signal quality
cmuhammedrafi Nov 13, 2025
4d8f8a4
updated code review
cmuhammedrafi Nov 13, 2025
1249239
RDKEMW-10336 - Update GetWiFiSignalQuality to use BSS SIGNAL_POLL
cmuhammedrafi Nov 13, 2025
9c560d2
Merge branch 'develop' into topic/RDKEMW-10336
karuna2git Nov 13, 2025
7bf86fb
Merge branch 'topic/RDKEMW-10336' of github.com:rdkcentral/networkman…
gururaajar Nov 13, 2025
11605ea
Merge branch 'topic/RDKEMW-10336' of github.com:rdkcentral/networkman…
gururaajar Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 80 additions & 46 deletions plugin/NetworkManagerImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ using namespace NetworkManagerLogger;

#define CIDR_NETMASK_IP_LEN 32
#define SSID_COMMAND "wpa_cli status"
#define BSS_COMMAND "wpa_cli bss"
#define SIGNAL_POLL_COMMAND "wpa_cli signal_poll"

namespace WPEFramework
{
Expand Down Expand Up @@ -841,116 +841,152 @@ namespace WPEFramework
/* The below implementation of GetWiFiSignalQuality is a temporary mitigation. Need to be revisited */
uint32_t NetworkManagerImplementation::GetWiFiSignalQuality(string& ssid /* @out */, string& strength /* @out */, string& noise /* @out */, string& snr /* @out */, WiFiSignalQuality& quality /* @out */)
{
uint32_t rc = Core::ERROR_RPC_CALL_FAILED;
int16_t readSnr = 0;

std::string key, value;
int16_t readNoise = 0;
string bssid{};
std::string key{}, value{}, bssid{}, band{};
char buff[512] = {'\0'};

FILE *fp = NULL;

/* SSID */
/* Get BSSID and SSID from wpa_cli status */
fp = popen(SSID_COMMAND, "r");
if (!fp)
{
NMLOG_ERROR("Failed in getting output from command %s",SSID_COMMAND);
return Core::ERROR_RPC_CALL_FAILED;
NMLOG_ERROR("Failed in getting output from command %s", SSID_COMMAND);
return Core::ERROR_GENERAL;
}
while ((!feof(fp)) && (fgets(buff, sizeof (buff), fp) != NULL)) {

while ((!feof(fp)) && (fgets(buff, sizeof (buff), fp) != NULL))
{
std::istringstream mystream(buff);
if(std::getline(std::getline(mystream, key, '=') >> std::ws, value))
{
if (key == "bssid") {
if (key == "ssid") {
ssid = value;
}
else if (key == "bssid") {
bssid = value;
break;
}
if (!ssid.empty() && !bssid.empty())
break;
}
}
pclose(fp);

/* Noise n RSSI */
std::string bssCommand = std::string(BSS_COMMAND) + " " + bssid;
fp = popen(bssCommand.c_str(), "r");
/* If BSSID is empty, WiFi is disconnected */
if (bssid.empty()) {
NMLOG_WARNING("WiFi is disconnected (BSSID is empty)");
quality = WiFiSignalQuality::WIFI_SIGNAL_DISCONNECTED;
ssid = "";
strength = "0";
noise = "0";
snr = "0";
return Core::ERROR_NONE;
}

/*Get real-time signal data from wpa_cli signal_poll */
fp = popen(SIGNAL_POLL_COMMAND, "r");
if (!fp)
{
NMLOG_ERROR("Failed in getting output from command %s",BSS_COMMAND);
return Core::ERROR_RPC_CALL_FAILED;
NMLOG_ERROR("Failed in getting output from command %s", SIGNAL_POLL_COMMAND);
return Core::ERROR_GENERAL;
}

while ((!feof(fp)) && (fgets(buff, sizeof (buff), fp) != NULL))
{
std::istringstream mystream(buff);
if(std::getline(std::getline(mystream, key, '=') >> std::ws, value))
{
if (key == "level") {
if (key == "RSSI") {
strength = value;
}
else if (key == "noise") {
else if (key == "NOISE") {
noise = value;
}
else if (key == "ssid") {
ssid = value;
else if (key == "AVG_RSSI") { // if RSSI is not available
if (strength.empty())
strength = value;
}
else if (key == "snr") {
snr = value;
else if (key == "FREQUENCY")
{
if (!value.empty())
{
int freq = std::stoi(value);
if (freq >= 2400 && freq < 5000)
band = "2.4GHz";
else if (freq >= 5000 && freq < 6000)
band = "5GHz";
else if (freq >= 6000)
band = "6GHz";
else
band = "not known";
}
}
if (!strength.empty() && !noise.empty() && !ssid.empty() && !snr.empty())
break;
}
}
pclose(fp);

/* NOTE: The std::stoi() will throw exception if the string input is empty; so set to 0 */
if (noise.empty())
noise= "0";
if (snr.empty())
snr = "0";
noise = "0";
if (strength.empty())
strength = "0";

readNoise = std::stoi(noise);
readSnr = std::stoi(snr);
int16_t readRssi = std::stoi(strength);
int16_t readNoise = std::stoi(noise);

/* Check the RSSI is within range between -10 and -100 dbm*/
if (readRssi >= 0 || readRssi < -100) {
NMLOG_WARNING("Received RSSI (%d dBm) is out of valid range (-10 to -100 dBm); Resetting to default", readRssi);
if (readRssi >= 0) {
readRssi = -10;
}
else if (readRssi < -100) {
readRssi = -100;
}
}

/* Check the Noise is within range between 0 and -96 dbm*/
if((readNoise >= 0) || (readNoise < DEFAULT_NOISE))
{
NMLOG_DEBUG("Received Noise (%d) from wifi driver is not valid; so clamping it", readNoise);
if (readNoise >= 0) {
readNoise = 0;
noise = std::to_string(0);
}
else if (readNoise < DEFAULT_NOISE) {
readNoise = DEFAULT_NOISE;
noise = std::to_string(DEFAULT_NOISE);
}
}

/*Calculate SNR = RSSI - Noise */
int16_t calculatedSnr = readRssi - readNoise;
snr = std::to_string(calculatedSnr);

/* mapping rssi value when the SNR value is not proper */
if(!(readSnr > 0 && readSnr <= MAX_SNR_VALUE))
if(!(calculatedSnr > 0 && calculatedSnr <= MAX_SNR_VALUE))
{
NMLOG_WARNING("Received SNR (%d) from wifi driver is not valid; Lets map with RSSI (%s)", readSnr, strength.c_str());
readSnr = std::stoi(strength);
NMLOG_WARNING("calculated SNR (%d) is not valid; Lets map with RSSI (%s)", calculatedSnr, strength.c_str());
calculatedSnr = std::stoi(strength);
/* Take the absolute value */
readSnr = (readSnr < 0) ? -readSnr : readSnr;
calculatedSnr = (calculatedSnr < 0) ? -calculatedSnr : calculatedSnr;

snr = std::to_string(readSnr);
snr = std::to_string(calculatedSnr);
}

NMLOG_INFO("RSSI: %s dBm; Noise: %s dBm; SNR: %s dBm", strength.c_str(), noise.c_str(), snr.c_str());
NMLOG_INFO("ssid=%s, bssid=%s, band=%s, rssi=%s, noise=%s, snr=%s", ssid.c_str(), bssid.c_str(), band.c_str(), strength.c_str(), noise.c_str(), snr.c_str());

if (readSnr == 0)
if (calculatedSnr == 0)
{
quality = WiFiSignalQuality::WIFI_SIGNAL_DISCONNECTED;
strength = "0";
}
else if (readSnr > 0 && readSnr < NM_WIFI_SNR_THRESHOLD_FAIR)
else if (calculatedSnr > 0 && calculatedSnr < NM_WIFI_SNR_THRESHOLD_FAIR)
{
quality = WiFiSignalQuality::WIFI_SIGNAL_WEAK;
}
else if (readSnr > NM_WIFI_SNR_THRESHOLD_FAIR && readSnr < NM_WIFI_SNR_THRESHOLD_GOOD)
else if (calculatedSnr >= NM_WIFI_SNR_THRESHOLD_FAIR && calculatedSnr < NM_WIFI_SNR_THRESHOLD_GOOD)
{
quality = WiFiSignalQuality::WIFI_SIGNAL_FAIR;
}
else if (readSnr > NM_WIFI_SNR_THRESHOLD_GOOD && readSnr < NM_WIFI_SNR_THRESHOLD_EXCELLENT)
else if (calculatedSnr >= NM_WIFI_SNR_THRESHOLD_GOOD && calculatedSnr < NM_WIFI_SNR_THRESHOLD_EXCELLENT)
{
quality = WiFiSignalQuality::WIFI_SIGNAL_GOOD;
}
Expand All @@ -959,9 +995,7 @@ namespace WPEFramework
quality = WiFiSignalQuality::WIFI_SIGNAL_EXCELLENT;
}

rc = Core::ERROR_NONE;

return rc;
return Core::ERROR_NONE;
}

void NetworkManagerImplementation::processMonitor(uint16_t interval)
Expand Down
51 changes: 22 additions & 29 deletions tests/l2Test/rdk/l2_test_rdkproxy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1313,7 +1313,7 @@ TEST_F(NetworkManagerTest, GetWiFiSignalQualityWpa_cliFailed)
TEST_F(NetworkManagerTest, GetWiFiSignalQualityDisconnected2)
{
EXPECT_CALL(*p_wrapsImplMock, popen(::testing::_, ::testing::_))
.Times(2)
.Times(1)
.WillOnce(::testing::Invoke(
[&](const char* command, const char* type) -> FILE* {
EXPECT_THAT(string(command), ::testing::MatchesRegex("wpa_cli status"));
Expand All @@ -1328,16 +1328,6 @@ TEST_F(NetworkManagerTest, GetWiFiSignalQualityDisconnected2)
rewind(tempFile);
}
return tempFile;
}))
.WillOnce(::testing::Invoke(
[&](const char* command, const char* type) -> FILE* {
EXPECT_THAT(string(command), ::testing::MatchesRegex("wpa_cli bss "));
FILE* tempFile = tmpfile();
if (tempFile) {
fputs("driver error", tempFile);
rewind(tempFile);
}
return tempFile;
}));

EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("GetWiFiSignalQuality"), _T("{}"), response));
Expand All @@ -1364,21 +1354,22 @@ TEST_F(NetworkManagerTest, GetWiFiSignalQualityConnected)
}))
.WillOnce(::testing::Invoke(
[&](const char* command, const char* type) -> FILE* {
EXPECT_THAT(string(command), ::testing::MatchesRegex("wpa_cli bss aa:bb:cc:dd:ee:ff"));
EXPECT_THAT(string(command), ::testing::MatchesRegex("wpa_cli signal_poll"));
FILE* tempFile = tmpfile();
if (tempFile) {
fputs("Selected interface 'wlan0'\n"
"ssid=dummySSID\n"
"noise=-117\n"
"level=-49\n"
"snr=65\n", tempFile);
"RSSI=-30\n"
"LINKSPEED=300\n"
"NOISE=-114\n"
"FREQUENCY=2417\n"
"AVG_RSSI=-30\n", tempFile);
rewind(tempFile);
}
return tempFile;
}));

EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("GetWiFiSignalQuality"), _T("{}"), response));
EXPECT_EQ(response, _T("{\"ssid\":\"dummySSID\",\"quality\":\"Excellent\",\"snr\":\"65\",\"strength\":\"-49\",\"noise\":\"-96\",\"success\":true}"));
EXPECT_EQ(response, _T("{\"ssid\":\"dummySSID\",\"quality\":\"Excellent\",\"snr\":\"66\",\"strength\":\"-30\",\"noise\":\"-96\",\"success\":true}"));
}

TEST_F(NetworkManagerTest, GetWiFiSignalQualityConnectedGood)
Expand All @@ -1401,21 +1392,22 @@ TEST_F(NetworkManagerTest, GetWiFiSignalQualityConnectedGood)
}))
.WillOnce(::testing::Invoke(
[&](const char* command, const char* type) -> FILE* {
EXPECT_THAT(string(command), ::testing::MatchesRegex("wpa_cli bss aa:bb:cc:dd:ee:ff"));
EXPECT_THAT(string(command), ::testing::MatchesRegex("wpa_cli signal_poll"));
FILE* tempFile = tmpfile();
if (tempFile) {
fputs("Selected interface 'wlan0'\n"
"ssid=dummySSID\n"
"noise=-30\n"
"level=-90\n"
"snr=33\n", tempFile);
"RSSI=\n"
"LINKSPEED=300\n"
"NOISE=-114\n"
"FREQUENCY=2417\n"
"AVG_RSSI=-90\n", tempFile);
rewind(tempFile);
}
return tempFile;
}));

EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("GetWiFiSignalQuality"), _T("{}"), response));
EXPECT_EQ(response, _T("{\"ssid\":\"dummySSID\",\"quality\":\"Good\",\"snr\":\"33\",\"strength\":\"-90\",\"noise\":\"-30\",\"success\":true}"));
EXPECT_EQ(response, _T("{\"ssid\":\"dummySSID\",\"quality\":\"Weak\",\"snr\":\"6\",\"strength\":\"-90\",\"noise\":\"-96\",\"success\":true}"));
}

TEST_F(NetworkManagerTest, GetWiFiSignalQualityConnectedLowBad)
Expand All @@ -1438,21 +1430,22 @@ TEST_F(NetworkManagerTest, GetWiFiSignalQualityConnectedLowBad)
}))
.WillOnce(::testing::Invoke(
[&](const char* command, const char* type) -> FILE* {
EXPECT_THAT(string(command), ::testing::MatchesRegex("wpa_cli bss aa:bb:cc:dd:ee:ff"));
EXPECT_THAT(string(command), ::testing::MatchesRegex("wpa_cli signal_poll"));
FILE* tempFile = tmpfile();
if (tempFile) {
fputs("Selected interface 'wlan0'\n"
"ssid=dummySSID\n"
"noise=9999\n"
"level=-120\n"
"snr=33\n", tempFile);
"RSSI=\n"
"LINKSPEED=300\n"
"NOISE=9999\n"
"FREQUENCY=5462\n"
"AVG_RSSI=-120\n", tempFile);
rewind(tempFile);
}
return tempFile;
}));

EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("GetWiFiSignalQuality"), _T("{}"), response));
EXPECT_EQ(response, _T("{\"ssid\":\"dummySSID\",\"quality\":\"Good\",\"snr\":\"33\",\"strength\":\"-120\",\"noise\":\"0\",\"success\":true}"));
EXPECT_EQ(response, _T("{\"ssid\":\"dummySSID\",\"quality\":\"Excellent\",\"snr\":\"120\",\"strength\":\"-120\",\"noise\":\"0\",\"success\":true}"));
}

TEST_F(NetworkManagerTest, Trace_Success_ipv4)
Expand Down
13 changes: 7 additions & 6 deletions tests/l2Test/rdk/l2_test_rdkproxyEvent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,22 +293,23 @@ TEST_F(NetworkManagerEventTest, onWiFiStateChange)
if (tempFile) {
fputs("Selected interface 'wlan0'\n"
"bssid=aa:bb:cc:dd:ee:ff\n"
"freq=5462\n"
"freq=2462\n"
"ssid=dummySSID\n", tempFile);
rewind(tempFile);
}
return tempFile;
}))
.WillOnce(::testing::Invoke(
[&](const char* command, const char* type) -> FILE* {
EXPECT_THAT(string(command), ::testing::MatchesRegex("wpa_cli bss aa:bb:cc:dd:ee:ff"));
EXPECT_THAT(string(command), ::testing::MatchesRegex("wpa_cli signal_poll"));
FILE* tempFile = tmpfile();
if (tempFile) {
fputs("Selected interface 'wlan0'\n"
"ssid=dummySSID\n"
"noise=-114\n"
"level=-90\n"
"snr=33\n", tempFile);
"RSSI=-30\n"
"LINKSPEED=300\n"
"NOISE=-114\n"
"FREQUENCY=2417\n"
"AVG_RSSI=-30\n", tempFile);
rewind(tempFile);
}
return tempFile;
Expand Down