Skip to content

Fix call for getting a md5 for a binary. Use lower case to save confusion. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2013
Merged

Fix call for getting a md5 for a binary. Use lower case to save confusion. #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dfc32e
Updating BinaryFile model function 'get_MD5' to use just lower case t…
rdobson Oct 10, 2013
165d7eb
Updating tests to specify the lower case 'get_md5' function.
rdobson Oct 10, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion driverfiles/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def get_loc(self):
def get_contents(self):
return utils.read_file(self.fileloc)

def get_MD5(self):
def get_md5(self):
fh = open(self.fileloc)
try:
md5sum = utils.md5_for_file(fh)
Expand Down
4 changes: 2 additions & 2 deletions driverfiles/tests/file_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def _generate_md5_file_for_binary(self):

def test_verify_md5(self):
bf = models.BinaryFile(self.TEST_FILE)
md5sum = bf.get_MD5()
md5sum = bf.get_md5()
assert_equal(self.md5_truth, md5sum)

def test_verify_filename(self):
Expand Down Expand Up @@ -157,7 +157,7 @@ def test_get_iso_md5(self):
fh = open(iso.get_loc())
truth_md5 = utils.md5_for_file(fh)
fh.close()
assert_equal(truth_md5, iso.get_MD5())
assert_equal(truth_md5, iso.get_md5())

def test_get_zip(self):
drp = models.DriverRepoPackage(self.directory)
Expand Down