Skip to content
This repository was archived by the owner on Sep 6, 2022. It is now read-only.

Commit a203d0f

Browse files
committed
refactor
1 parent ddb4412 commit a203d0f

File tree

16 files changed

+9
-25
lines changed

16 files changed

+9
-25
lines changed

app/app.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import LanguageProvider from 'containers/LanguageProvider';
2525

2626
// Load the favicon and the .htaccess file
2727
import '!file-loader?name=[name].[ext]!./images/favicon.ico';
28-
import 'file-loader?name=.htaccess!./.htaccess'; // eslint-disable-line import/extensions
28+
import 'file-loader?name=.htaccess!./.htaccess';
2929

3030
import configureStore from './configureStore';
3131

@@ -79,7 +79,7 @@ if (!(window as any).Intl) {
7979
import('intl/locale-data/jsonp/en.js'),
8080
import('intl/locale-data/jsonp/de.js'),
8181
]),
82-
) // eslint-disable-line prettier/prettier
82+
)
8383
.then(() => render(translationMessages))
8484
.catch(err => {
8585
throw err;

app/configureStore.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export default function configureStore(initialState = {}, history) {
2020
// If Redux Dev Tools and Saga Dev Tools Extensions are installed, enable them
2121
/* istanbul ignore next */
2222
if (process.env.NODE_ENV !== 'production' && typeof window === 'object') {
23-
/* eslint-disable no-underscore-dangle */
2423
if (window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__) {
2524
composeEnhancers = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__({});
2625
}
@@ -31,7 +30,6 @@ export default function configureStore(initialState = {}, history) {
3130
// reduxSagaMonitorOptions = {
3231
// sagaMonitor: window.__SAGA_MONITOR_EXTENSION__,
3332
// };
34-
/* eslint-enable */
3533
}
3634

3735
const sagaMiddleware = createSagaMiddleware(reduxSagaMonitorOptions);

app/containers/App/tests/reducer.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import appReducer from '../reducer';
22
import { loadRepos, reposLoaded, repoLoadingError } from '../actions';
33
import { ContainerState } from '../types';
44

5-
/* eslint-disable default-case, no-param-reassign */
65
describe('appReducer', () => {
76
let state: ContainerState;
87
beforeEach(() => {

app/containers/HomePage/tests/reducer.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import homeReducer from '../reducer';
22
import { changeUsername } from '../actions';
33
import { ContainerState } from '../types';
44

5-
/* eslint-disable default-case, no-param-reassign */
65
describe('homeReducer', () => {
76
let state: ContainerState;
87
beforeEach(() => {

app/containers/HomePage/tests/saga.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import githubData, { getRepos } from '../saga';
1111

1212
const username = 'mxstbr';
1313

14-
/* eslint-disable redux-saga/yield-effects */
1514
describe('getRepos Saga', () => {
1615
let getReposGenerator;
1716

app/containers/LanguageProvider/tests/reducer.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import languageProviderReducer from '../reducer';
22
import ActionTypes from '../constants';
33

4-
/* eslint-disable default-case, no-param-reassign */
54
describe('languageProviderReducer', () => {
65
it('returns the initial state', () => {
76
expect(languageProviderReducer(undefined, {} as any)).toEqual({

app/tests/store.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,9 @@ describe('configureStore', () => {
3333

3434
describe('configureStore params', () => {
3535
it('should call window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__', () => {
36-
/* eslint-disable no-underscore-dangle */
3736
const compose = jest.fn();
3837
(window as any).__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ = () => compose;
3938
configureStore(undefined, browserHistory);
4039
expect(compose).toHaveBeenCalled();
41-
/* eslint-enable */
4240
});
4341
});

app/utils/reducerInjectors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export function injectReducerFactory(store: InjectedStore, isValid: boolean = fa
2929
return;
3030
}
3131

32-
store.injectedReducers[key] = reducer; // eslint-disable-line no-param-reassign
32+
store.injectedReducers[key] = reducer;
3333
store.replaceReducer(createReducer(store.injectedReducers));
3434
};
3535
}

app/utils/sagaInjectors.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,10 @@ export function injectSagaFactory(store: InjectedStore, isValid: boolean = false
6767
!hasSaga ||
6868
(hasSaga && mode !== DAEMON && mode !== ONCE_TILL_UNMOUNT)
6969
) {
70-
/* eslint-disable no-param-reassign */
7170
store.injectedSagas[key] = {
7271
...newDescriptor,
7372
task: store.runSaga(saga, args),
7473
};
75-
/* eslint-enable no-param-reassign */
7674
}
7775
};
7876
}
@@ -93,7 +91,7 @@ export function ejectSagaFactory(store: InjectedStore, isValid: boolean = false)
9391
// Clean up in production; in development we need `descriptor.saga` for hot reloading
9492
if (process.env.NODE_ENV === 'production') {
9593
// Need some value to be able to detect `ONCE_TILL_UNMOUNT` sagas in `injectSaga`
96-
store.injectedSagas[key] = 'done'; // eslint-disable-line no-param-reassign
94+
store.injectedSagas[key] = 'done';
9795
}
9896
}
9997
}

internals/templates/app.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import LanguageProvider from 'containers/LanguageProvider';
2525

2626
// Load the favicon and the .htaccess file
2727
import '!file-loader?name=[name].[ext]!./images/favicon.ico';
28-
import 'file-loader?name=.htaccess!./.htaccess'; // eslint-disable-line import/extensions
28+
import 'file-loader?name=.htaccess!./.htaccess';
2929

3030
import configureStore from './configureStore';
3131

@@ -79,7 +79,7 @@ if (!(window as any).Intl) {
7979
import('intl/locale-data/jsonp/en.js'),
8080
import('intl/locale-data/jsonp/de.js'),
8181
]),
82-
) // eslint-disable-line prettier/prettier
82+
)
8383
.then(() => render(translationMessages))
8484
.catch(err => {
8585
throw err;

0 commit comments

Comments
 (0)