Merge dev into master #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copy code and tests from rbp to this library - Create API: `createInjectorsEnhancer` (new), `injectSaga`, `useInjectSaga`, `injectReducer`, `useInjectReducer`, `forceReducerReload` (new), `SagaInjectionModes` - Setup jest - Setup babel - Committed `package-lock.json` file - Ensure lodash imports aren't importing all of lodash - Remove props from being forwarded to saga when using `injectSaga`
Collaborator
Author
|
I wonder if we should do a merge commit instead of squash merge dev -> master? Just so we maintain the history? |
Member
|
Yes, we can do that. (Not that we wouldn't truly lose the commit history. The Also, this is your 1.0 release. It needs a release to go with it. |
Collaborator
Author
|
Sure thing, do I create the release before or after we merge this? |
Member
|
I believe it goes in this order:
Maybe take a look at an article like this to make sure we covered everything? (Also, I enabled merge commits. Let's try to remember to use them only for merging dev into master.) |
Collaborator
Author
|
Ok, sounds good. If you can approve this I can merge and create the release. |
julienben
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.