Skip to content

Commit 90cada4

Browse files
committed
tuning the wording for test and documents
1 parent 249f8a6 commit 90cada4

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

docs/columns.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ A new `Object` will be the result of element headerAttrs.
423423
424424
### <a name='headerSortingClasses'>headerSortingClasses - [String | Function]</a>
425425

426-
`headerSortingClasses` allows to customize `class` for header cell which the table was sorting based on.
426+
`headerSortingClasses` allows to customize `class` for header cell when this column is sorting.
427427

428428
```js
429429
const headerSortingClasses = 'demo-sorting';
@@ -437,12 +437,12 @@ const headerSortingClasses = (column, sortOrder, isLastSorting, colIndex) => { .
437437

438438
* `column`: The value of current column.
439439
* `sortOrder`: The order of current sorting
440-
* `isLastSorting`: Is the last one of sorting.
440+
* `isLastSorting`: Is the last one of sorted columns.
441441
* `colIndex`: The index of the current column being processed in BootstrapTable.
442442

443443
### <a name='headerSortingStyle'>headerSortingStyle - [Object | Function]</a>
444444

445-
It's similiar to [headerSortingClasses](#headerSortingClasses). It allows to customize the style of header cell which the table was sorting based on. A style `Object` and `callback` are acceptable. `callback` takes **4** arguments and an `Object` is expected to return:
445+
It's similiar to [headerSortingClasses](#headerSortingClasses). It allows to customize the style of header cell when this column is sorting. A style `Object` and `callback` are acceptable. `callback` takes **4** arguments and an `Object` is expected to return:
446446

447447
```js
448448
const sortingHeaderStyle = {

packages/react-bootstrap-table2-example/stories/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@ storiesOf('Sort Table', module)
130130
.add('Enable Sort', () => <EnableSortTable />)
131131
.add('Default Sort Table', () => <DefaultSortTable />)
132132
.add('Custom Sort Fuction', () => <CustomSortTable />)
133-
.add('Header sorting classes', () => <HeaderSortingClassesTable />)
134-
.add('Header sorting style', () => <HeaderSortingStyleTable />);
133+
.add('Custom Classes on Sorting Header Column', () => <HeaderSortingClassesTable />)
134+
.add('Custom Style on Sorting Header Column', () => <HeaderSortingStyleTable />);
135135

136136
storiesOf('Cell Editing', module)
137137
.add('Click to Edit', () => <ClickToEditTable />)

packages/react-bootstrap-table2/test/header-cell.test.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ describe('HeaderCell', () => {
437437
});
438438
});
439439

440-
describe('when headerSortingClasses was defined ', () => {
440+
describe('when headerSortingClasses is defined ', () => {
441441
const classes = 'foo';
442442
const order = Const.SORT_DESC;
443443

@@ -453,7 +453,7 @@ describe('HeaderCell', () => {
453453
/>);
454454
});
455455

456-
it('should append classes correcly', () => {
456+
it('should append classes correctly', () => {
457457
expect(wrapper.length).toBe(1);
458458
expect(wrapper.hasClass(classes)).toBe(true);
459459
});
@@ -482,7 +482,7 @@ describe('HeaderCell', () => {
482482
/>);
483483
});
484484

485-
it('should append classes correcly', () => {
485+
it('should append classes correctly', () => {
486486
expect(wrapper.length).toBe(1);
487487
expect(wrapper.hasClass(classes)).toBe(true);
488488
});
@@ -516,7 +516,7 @@ describe('HeaderCell', () => {
516516
});
517517
});
518518

519-
describe('if column.headerClasses was defined as well', () => {
519+
describe('if column.headerClasses is defined as well', () => {
520520
it('should keep both classes', () => {
521521
column = {
522522
...column,
@@ -541,7 +541,7 @@ describe('HeaderCell', () => {
541541
});
542542
});
543543

544-
describe('when headerSortingStyle was defined', () => {
544+
describe('when headerSortingStyle is defined', () => {
545545
const style = { backgroundColor: 'red' };
546546
const order = Const.SORT_DESC;
547547

@@ -559,7 +559,7 @@ describe('HeaderCell', () => {
559559
);
560560
});
561561

562-
it('should append style correcly', () => {
562+
it('should append style correctly', () => {
563563
expect(wrapper.length).toBe(1);
564564
expect(wrapper.find('th').prop('style')).toEqual(style);
565565
});
@@ -585,7 +585,7 @@ describe('HeaderCell', () => {
585585
/>);
586586
});
587587

588-
it('should append style correcly', () => {
588+
it('should append style correctly', () => {
589589
expect(wrapper.length).toBe(1);
590590
expect(wrapper.find('th').prop('style')).toEqual(style);
591591
});

0 commit comments

Comments
 (0)