case insensitive text filter

[makenova]

For issue #189

[AllenFang]

@makenova how about we make it configurable ?! Keep current behavior as default and add case insensitive props, if ok, I can show you how to change or I can handle it, thanks

[AllenFang]

is that danger? for example \test\ or \\test\\, maybe throw some err?

[makenova]

Like if the filterVal is \test\?
I’ll do some testing to see if that can cause an error.

[AllenFang]

yes, thanks !!

[makenova]

Making it configureable is a great idea!
Pls show me how you’d like it changed.

[AllenFang]

@makenova I think we can allow the text filter to have caseInsensitive via textFilter props.
Currently, text and select filter allow user to configure some thing, check this example, I think you can have the same way to do it.

add a new caseSensitive props for text filter
then on here get caseSensitive props, for example:

else {
        // select default comparator is EQ, others are LIKE
        const { comparator = (filterType === FILTER_TYPE.SELECT ? EQ : LIKE) } = filter.props;
        const caseSensitive = filter.props.caseSensitive || false;
        currFilters[dataField] = { filterVal, filterType, comparator, caseSensitive };
}
store.filters = currFilters;

then in https://github.com/react-bootstrap-table/react-bootstrap-table2/blob/master/packages/react-bootstrap-table2-filter/src/filter.js#L19, depends on the caseSensitive value to filter data.

Let me know if you got any question, thank you

[makenova]

I've updated it with caseSensitive props and moved away for using RegExp.

[AllenFang]

LGTM

[AllenFang]

@makenova thanks your contribution 👍

[AllenFang]

#201 . @makenova