Skip to content

pass whole popperConfig to PopperJS (#748) #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2020
Merged

pass whole popperConfig to PopperJS (#748) #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
453ff44
pass whole popperConfig to PopperJS (#748)
Dec 9, 2019
a0ecb67
pass whole popperConfig to PopperJS (#748)
Dec 10, 2019
892401c
pass whole popperConfig to PopperJS (#748)
Dec 10, 2019
4709d00
Revert "pass whole popperConfig to PopperJS (#748)"
Dec 11, 2019
c56c30c
use popperOptions in usePopper (#748)
Dec 11, 2019
c51e43d
Merge branch 'master' into master
taion Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/DropdownMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export function useDropdownMenu(options = {}) {
const modifiers = toModifierMap(popperConfig.modifiers);

const popper = usePopper(toggleElement, menuElement, {
...popperConfig,
placement,
enabled: !!(shouldUsePopper && show),
modifiers: {
Expand Down
4 changes: 4 additions & 0 deletions src/usePopper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ export function toModifierArray(map) {
* @param {String} options.placement The popper element placement relative to the reference element
* @param {Boolean} options.positionFixed use fixed positioning
* @param {Boolean} options.eventsEnabled have Popper listen on window resize events to reposition the element
* @param {Function} options.onCreate called when the popper is created
* @param {Function} options.onUpdate called when the popper is updated
*/
export default function usePopper(
referenceElement,
Expand All @@ -74,6 +76,7 @@ export default function usePopper(
strategy = 'absolute',
eventsEnabled = true,
modifiers: userModifiers,
...popperOptions
} = {},
) {
const popperInstanceRef = useRef();
Expand Down Expand Up @@ -152,6 +155,7 @@ export default function usePopper(
}

popperInstanceRef.current = createPopper(referenceElement, popperElement, {
...popperOptions,
placement,
strategy,
modifiers: [...modifiers, updateModifier],
Expand Down