feat: add api to change visibility of popup overlay when finishing ca… #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
afc163
reviewed
Jul 12, 2021
README.md
Outdated
| <td>specific the default loading icon</td> | ||
| </tr> | ||
| <tr> | ||
| <td>popupVisibleAfterSelect</td> |
Member
There was a problem hiding this comment.
Suggested change
| <td>popupVisibleAfterSelect</td> | |
| <td>hidePopupOnSelect</td> |
Member
|
来一些测试用例。 |
Contributor
Author
加了 |
afc163
reviewed
Jul 13, 2021
| .hasClass('rc-cascader-menu-item-active'), | ||
| ).toBe(true); | ||
|
|
||
| expect(wrapper.state().popupVisible).toBeTruthy(); |
Member
There was a problem hiding this comment.
开启 hidePopupOnSelect 后，还是可以 blur 隐藏的吧？
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=======================================
Coverage 92.96% 92.96%
=======================================
Files 4 4
Lines 270 270
Branches 94 94
=======================================
Hits 251 251
Misses 19 19
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加 api 以在完成级联选择时更改弹窗的可见性
弹窗默认在选中最后一级后自动关闭。这一逻辑导致级联选择不能实现多选的功能。
想增加一个api: popupVisibleAfterSelect，如果为true，handleChange 后不会默认关闭。点击弹窗之外依然会关闭。
点击最后一级后自动关闭示意图：
