Skip to content

fix: should trigger onChange if click on options of multiple cascader with searchValue #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2022
Merged

fix: should trigger onChange if click on options of multiple cascader with searchValue #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35a67b5
fix: should trigger onChange if click on options of multiple cascader…
MadCcc Jan 13, 2022
f49d0d8
chore: update comment
MadCcc Jan 13, 2022
737b563
test: cover mousedown
MadCcc Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Cascader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ const Cascader = React.forwardRef<CascaderRef, InternalCascaderProps>((props, re

// =========================== Select ===========================
const onInternalSelect = useRefFunc((valuePath: SingleValueType) => {
setSearchValue('');
if (!multiple) {
triggerChange(valuePath);
} else {
Expand Down
4 changes: 4 additions & 0 deletions src/OptionList/Column.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ export default function Column({
triggerOpenPath();
}
}}
onMouseDown={e => {
// Prevent selector from blurring
e.preventDefault();
}}
>
{multiple && (
<Checkbox
Expand Down
11 changes: 11 additions & 0 deletions tests/search.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,4 +177,15 @@ describe('Cascader.Search', () => {

errorSpy.mockRestore();
});

it('onChange should be triggered when click option with multiple', () => {
const onChange = jest.fn();
const wrapper = mount(
<Cascader checkable options={options} changeOnSelect onChange={onChange} showSearch />,
);
doSearch(wrapper, 'toy');
wrapper.find('.rc-cascader-menu-item').first().simulate('click');
wrapper.find('.rc-cascader-menu-item').first().simulate('mousedown');
expect(onChange).toHaveBeenCalledWith([['bamboo', 'little', 'fish']], expect.anything());
});
});