Skip to content

Conversation

delesseps
Copy link

  • Focus and blurring a field with validation rules without changing the value should not cause it to be 'touched'
  • Changing a field value back to it's initial value should restore the untouched state

- Focus and blurring a field with validation rules without changing the value should not cause it to be 'touched'
- Changing a field value back to it's initial value should restore the untouched state
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 93.478% when pulling 3300858 on delesseps:master into 4835142 on react-component:master.

@delesseps
Copy link
Author

Hi @benjycui, as per the documentation http://react-component.github.io/form/#isfieldtouched(name:-string):-bool, making sure that this works properly. Please take a look.

@delesseps
Copy link
Author

@benjycui do you see any issues?

@delesseps
Copy link
Author

@afc163 you helped me out with the /switch PR, perhaps you can review this please?

@delesseps
Copy link
Author

WakeUpCat

@jch254
Copy link

jch254 commented Aug 7, 2017

👍 please merge/review this as I am being affected by this issue too

@afc163 afc163 requested a review from benjycui August 7, 2017 01:48
@benjycui
Copy link
Member

Focus and blurring a field with validation rules without changing the value should not cause it to be 'touched'
Changing a field value back to it's initial value should restore the untouched state

I don't agree, touched is not dirty

@benjycui
Copy link
Member

It's hard to say which is right.. Could you show other form's behavior?

@delesseps
Copy link
Author

We could create a parallel dirty tracking pathway? The dirty state is pretty useful as it can then be used in conjunction with a reset button or used to show warning prompts for preventing route/url changes. What are your thoughts @benjycui?

@delesseps
Copy link
Author

Closing for now, will check the state of play in latest ant3

@delesseps delesseps closed this Dec 19, 2017
@jch254
Copy link

jch254 commented Dec 20, 2017

Will check it in ant3 too, thanks for top work squad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants