Skip to content

Conversation

@kerm1it
Copy link
Member

@kerm1it kerm1it commented Jan 20, 2021

@vercel
Copy link

vercel bot commented Jan 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/r0rg64ibz
✅ Preview: https://input-number-git-fix-15682.react-component.vercel.app

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #290 (a3a6ef4) into master (ace15ec) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   93.04%   93.12%   +0.07%     
==========================================
  Files           1        1              
  Lines         374      378       +4     
  Branches      129      134       +5     
==========================================
+ Hits          348      352       +4     
  Misses         26       26              
Impacted Files Coverage Δ
src/InputNumber.tsx 93.12% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace15ec...a3a6ef4. Read the comment docs.

@xrkffgg
Copy link
Member

xrkffgg commented Jan 20, 2021

光标会移动到前面,有办法保持原样吗?

@kerm1it
Copy link
Member Author

kerm1it commented Jan 20, 2021

好了,部署完了再看看

@kerm1it kerm1it requested a review from afc163 January 20, 2021 05:14
@zombieJ
Copy link
Member

zombieJ commented Jan 21, 2021

好像拦截有时候有用,有时候没用:
Kapture 2021-01-21 at 14 30 55

@kerm1it
Copy link
Member Author

kerm1it commented Jan 21, 2021

例子只拦截了 Up 键,其他都正常,😂

@zombieJ
Copy link
Member

zombieJ commented Jan 21, 2021

能改个标准的例子不?方便我瞎点点~

@kerm1it
Copy link
Member Author

kerm1it commented Jan 21, 2021

你说了后我试了试,才发现阻止后,连普通的数字都不能输入了😂,差点出大事儿。

@xrkffgg
Copy link
Member

xrkffgg commented Jan 21, 2021

没禁用时,向上 光标动了

@kerm1it
Copy link
Member Author

kerm1it commented Jan 21, 2021

@zombieJ @xrkffgg 还是感觉 onKeydown 后面追加一个参数比较好,注入的话,用户调用 e.preventDefault 的话,有可能会连正常的输入都会阻止掉。

@zombieJ
Copy link
Member

zombieJ commented Jan 22, 2021

唔……那是不是干脆加个属性算了,也不用勉强做成 preventDefault 了。

@kerm1it
Copy link
Member Author

kerm1it commented Jan 22, 2021

唔……那是不是干脆加个属性算了,也不用勉强做成 preventDefault 了。

👌,起个什么名字好呢😂

@zombieJ
Copy link
Member

zombieJ commented Jan 22, 2021

😂 想了半天都找不到适合的名字,感觉如果有个 controller 似乎又太笨重了。要不然和 trigger 一样有个 actionkeyboard arrow?觉得又毫无必要……

changeByArrow? 脑壳痛……

@kerm1it
Copy link
Member Author

kerm1it commented Jan 22, 2021

可不可以给 onKeyDown 加个类型,如果是 false 就取消自增自减功能?

@afc163
Copy link
Member

afc163 commented Jan 22, 2021

keyboard: boolean 就好了,目前也没别的快键键。

@kerm1it
Copy link
Member Author

kerm1it commented Jan 22, 2021

@afc163 @zombieJ 可以了,加了 keyboard 这个属性。

@kerm1it
Copy link
Member Author

kerm1it commented Jan 27, 2021

@zombieJ 改好了

@zombieJ zombieJ merged commit 9ca13c2 into master Jan 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-15682 branch January 27, 2021 03:48
@zombieJ
Copy link
Member

zombieJ commented Jan 27, 2021

+ rc-input-number@6.2.0

@kerm1it kerm1it changed the title feat: onKeyDown support preventDefault feat: support keyboard prop Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

希望 InputNumber 可以允许取消上下方向键的自增或自减功能

5 participants