Skip to content

fix: check mergePrecision should consider zero #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2021
Merged

fix: check mergePrecision should consider zero #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9323b2f
fix: check mergePrecision should consider zero
jameslahm Apr 7, 2021
59bece5
style: lint
Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/InputNumber.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ const InputNumber = React.forwardRef(
if (!readOnly && !disabled) {
const numStr = updateValue.toString();
const mergedPrecision = getPrecision(numStr, userTyping);
if (mergedPrecision) {
if (mergedPrecision >= 0) {
updateValue = getMiniDecimal(toFixed(numStr, '.', mergedPrecision));
}

Expand Down
10 changes: 10 additions & 0 deletions tests/decimal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,16 @@ describe('InputNumber.Decimal', () => {
expect(wrapper.getInputValue()).toEqual('1.00');
});

it('zero precision should work',()=>{
const onChange = jest.fn();
const wrapper = mount(<InputNumber onChange={onChange} precision={0} />);

wrapper.changeValue('1.44');
wrapper.blurInput();
expect(onChange).toHaveBeenCalledWith(1);
expect(wrapper.getInputValue()).toEqual('1');
})

it('should not trigger onChange when blur InputNumber with precision', () => {
const onChange = jest.fn();
const wrapper = mount(<InputNumber precision={2} defaultValue={2} onChange={onChange} />);
Expand Down