Skip to content

Conversation

@fnimick
Copy link
Contributor

@fnimick fnimick commented Sep 16, 2022

Resolves #481

@vercel
Copy link

vercel bot commented Sep 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
input-number ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 7:19PM (UTC)

@afc163
Copy link
Member

afc163 commented Sep 17, 2022

@li-jia-nan

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #482 (0345da7) into master (be9a52f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #482   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files           7        7           
  Lines         436      436           
  Branches      117      117           
=======================================
  Hits          426      426           
  Misses         10       10           
Impacted Files Coverage Δ
src/InputNumber.tsx 98.40% <ø> (ø)
src/utils/MiniDecimal.ts 96.12% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@li-jia-nan
Copy link
Member

@li-jia-nan

好像没问题,我上周也打算把这个 ValueType 中的null去掉~~

@afc163 afc163 merged commit 20db787 into react-component:master Sep 19, 2022
@zombieJ
Copy link
Member

zombieJ commented Sep 19, 2022

This breaks control usage:
截屏2022-09-19 15 32 55

截屏2022-09-19 15 33 12

value & onChange should both support null or both not support null.

@li-jia-nan
Copy link
Member

This breaks control usage: 截屏2022-09-19 15 32 55

截屏2022-09-19 15 33 12

value & onChange should both support null or both not support null.

@fnimick fnimick deleted the fnimick/fix-valuetype branch September 19, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type of ValueType is incorrect - is string | number | null, should be string | number

4 participants