refactor: refactor with Baseinput #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MuxinFeng
commented
May 28, 2023
MuxinFeng
commented
- Rc-input-number 引入 BaseInput，这里参考 rc-input, rc-textarea, rc-mentions，把 antd 那里传过来的一些 props 又传到 BaseInput 里了，包括但不限于 addonBefore、addonAfter、prefix。
- 之前 antd-design 中，addonBefore 等属性没有传到 rc-input-number 里管理，参考 input 做了下调整。
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MadCcc
reviewed
May 29, 2023
Member
|
相关的 test case 也可以挪过来，antd 那边的也不用删，留着验证 |
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
- Coverage 94.75% 94.18% -0.58%
==========================================
Files 6 6
Lines 267 275 +8
Branches 69 71 +2
==========================================
+ Hits 253 259 +6
- Misses 14 16 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
20 tasks
MadCcc
reviewed
Jun 6, 2023
| tabIndex?: number; | ||
| controls?: boolean; | ||
| prefix?: React.ReactNode; | ||
| suffix?: React.ReactNode; |
Member
There was a problem hiding this comment.
Suggested change
| suffix?: React.ReactNode; |
暂时不支持 suffix
Contributor
Author
There was a problem hiding this comment.
这里是准备放 feedbackIcon 的，antd 的 InputNumber 并没有暴露 suffix 。
MadCcc
approved these changes
Jun 6, 2023
20 tasks
20 tasks
Member
|
It seems that the README document has not been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.