Skip to content

Fix cascade effect #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 28, 2018
Merged

Fix cascade effect #22

merged 4 commits into from
Dec 28, 2018

Conversation

@oMaten
Copy link
Collaborator

@oMaten oMaten commented Sep 4, 2018

Fixes #21

@coveralls
Copy link

coveralls commented Sep 4, 2018 •
edited
Loading

Coverage Status

Coverage increased (+1.6%) to 87.037% when pulling cdf65d2 on oMaten:fix-cascade-effect into 22f8b4d on react-component:master.

@ziluo ziluo requested a review from warmhug September 4, 2018 09:21
@ziluo
Copy link
Contributor

ziluo commented Sep 4, 2018

+1

@oMaten
Copy link
Collaborator Author

oMaten commented Sep 5, 2018

Another problem is that if value property is settled, the cascade effect will be broken.
I remove the conditional judgement since it will ignore to change the value state. @warmhug

@ziluo
Copy link
Contributor

ziluo commented Dec 28, 2018

+1

@ziluo ziluo merged commit ccadb7d into react-component:master Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warmhug warmhug Awaiting requested review from warmhug

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oMaten @coveralls @ziluo