add onScrollChange event, ref antd-mobile/#1447. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silentcloud
reviewed
Sep 19, 2017
src/MultiPickerMixin.tsx
Outdated
| import MultiPickerProps from './MultiPickerProps'; | ||
|
|
||
| export default function(ComposedComponent) { | ||
| export default function (ComposedComponent) { |
silentcloud
reviewed
Sep 19, 2017
| this.props.onValueChange!(value, i); | ||
| } | ||
|
|
||
| onScrollChange = (i, v) => { |
Member
There was a problem hiding this comment.
和 onValueChange 合并一下吧，实现都一样，减小体积
Member
Author
There was a problem hiding this comment.
不太能合并。。。onValueChange这个事件目前的定义是onScrollComplete，会有setState等一系列操作，而onScrollChange是滚动过程中的事件
Member
There was a problem hiding this comment.
我是说和上面这个代码 onValueChange = (i, v) => {，抽出一个公共方法
Member
|
@zhang740 web 和 rn（注意 android） 都测一下，没问题就合了 |
Member
Author
|
@silentcloud 应该没什么问题了，RN部分没改，测了下没啥问题，web部分也测了下没啥问题。 |
Member
|
picker 和 mutilpePicker的 mixin rn 都有用到，如果 rn 不打算支持 onScrollChange 的话那就没啥问题 |
Member
Author
|
@silentcloud RN后续有需求再说吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.