Skip to content

Conversation

@kerm1it
Copy link
Member

@kerm1it kerm1it commented Jun 8, 2020

@kerm1it
Copy link
Member Author

kerm1it commented Jun 8, 2020

@afc163 我按照 antd 的 Textarea 做的,后期看要不要考虑将 antd 的 Textarea 提出来?

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #27 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   99.09%   99.08%   -0.01%     
==========================================
  Files           6        6              
  Lines         220      219       -1     
  Branches       48       48              
==========================================
- Hits          218      217       -1     
  Misses          2        2              
Impacted Files Coverage Δ
src/Mentions.tsx 99.23% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2191b...653d437. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jun 8, 2020

可以的,提成一个 rc-textarea

@afc163
Copy link
Member

afc163 commented Jun 8, 2020

@kerm1it
Copy link
Member Author

kerm1it commented Jun 8, 2020

OK, 那我明天把 antd 的 Textarea 抽出去。

@kerm1it
Copy link
Member Author

kerm1it commented Jun 10, 2020

@afc163 我把 antd 的 textarea 已经抽取出来了,但是其中的 allowClear 功能没有拿出来,觉得这是属于额外功能,不属于必需功能,你看看要不要加进去?

@afc163
Copy link
Member

afc163 commented Jun 11, 2020

没必要,先提重复的代码就好。

@kerm1it
Copy link
Member Author

kerm1it commented Jun 11, 2020

OK,那我这已经改完了。

@afc163
Copy link
Member

afc163 commented Jun 11, 2020

你可以发了 rc-textarea 然后回来改这里和 antd。

@kerm1it
Copy link
Member Author

kerm1it commented Jun 11, 2020

用我自己的账号发么?还是CI里面有发布?

@afc163
Copy link
Member

afc163 commented Jun 11, 2020

用你账号发就行了。

@kerm1it
Copy link
Member Author

kerm1it commented Jun 11, 2020

替换完了,我测试了mentions的功能都正常。

@afc163 afc163 merged commit 306a93b into react-component:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants