Allow passing custom placements config #112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenykochetkov
force-pushed
the
allow-passing-custom-placements-map
branch
from
ab2085b to
0619ac7
Compare
Merged
Member
|
@benjycui 帮忙 review 下 cc @valleykid |
benjycui
reviewed
Jan 2, 2018
README.md
Outdated
| <td>Where to render the DOM node of popup menu when the mode is horizontal or vertical</td> | ||
| </tr> | ||
| <tr> | ||
| <td>popupPlacements</td> |
Member
There was a problem hiding this comment.
How about builtinPlacements? To be consistent with rc-trigger
Member
|
Code is OK, just update the API name. |
Addresses one of the problems described in react-component#108
evgenykochetkov
force-pushed
the
allow-passing-custom-placements-map
branch
from
0619ac7 to
174c6ab
Compare
Member
|
Conflict |
Contributor
|
@evgenykochetkov will you be able to do a rebase? Let's close this one soon if possible, thanks! |
|
@picodoth Would be nice to update the examples page with an example similar to this one #122 (comment) |
Contributor
|
seeing #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses one of the problems described in #108