perf: refactor to avoid unnecessary re-render with mini-store #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picodoth
commented
Mar 14, 2018
src/MenuMixin.js
Outdated
| }, () => { | ||
| updateActiveKey(this.getStore(), this.getEventKey(), activeItem.props.eventKey); | ||
|
|
||
| /* TODO |
Contributor
Author
There was a problem hiding this comment.
@yesmeck how do we do setState callback?
Member
There was a problem hiding this comment.
scrollIntoView 可以放到 componentDidUpdate 里。
callback(activeItem); 这句好像放在 callback 外也没影响。
yesmeck
reviewed
Mar 19, 2018
| selectedKeys, | ||
| openKeys, | ||
| }; | ||
| activeKey: { '0-menu-': getActiveKey(props, props.activeKey) }, |
Member
There was a problem hiding this comment.
activeKey 是不是只要数组就可以了？因为 key 是全局唯一的。
Contributor
Author
There was a problem hiding this comment.
key是全局唯一的，但是activeKey不是，每层都有一个，这样get操作也比较方便。
Member
There was a problem hiding this comment.
activeKey 应该是跟 openKeys 类似的。里面包含的 key 是唯一的。
yesmeck
reviewed
Mar 20, 2018
src/SubMenu.jsx
Outdated
| export default SubMenu; | ||
| export default connect(({ openKeys, activeKey }, { eventKey }) => ({ | ||
| // k is of type integer, and eventKey is of type string | ||
| isOpen: openKeys.findIndex((k) => k === eventKey) > -1, |
yesmeck
reviewed
Mar 20, 2018
src/MenuItem.jsx
Outdated
| export default MenuItem; | ||
| export default connect(({ activeKey, selectedKeys }, { eventKey }) => ({ | ||
| active: activeKey[getMenuIdFromItemEventKey(eventKey)] === eventKey, | ||
| isSelected: selectedKeys.findIndex((k) => k === eventKey) !== -1, |
Member
|
https://ant.design/components/menu/#components-menu-demo-sider-current 这个例子里，keyboard 的行为不一样了。 |
Contributor
Author
yesmeck
reviewed
Mar 28, 2018
| {React.Children.map(props.children, this.renderMenuItem)} | ||
| {React.Children.map( | ||
| props.children, | ||
| (c, i, subIndex) => this.renderMenuItem(c, i, subIndex, props.eventKey || '0-menu-'), |
Contributor
Author
There was a problem hiding this comment.
subIndex是啥啊，我这部分code相当于没动，只是加了一个参数。我看下subIndex是啥
Member
|
有个新问题, hover 子菜单标题的时候会 active 第一个 menu item。
|
Contributor
Author
|
@yesmeck 恩 回头我看下 应该是小问题 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using mini store to subscribe local change to improve performance.
Before:
After:
Notes:
TODO items: