fix: regression #138
Merged
fix: regression #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picodoth
changed the title
picodoth
force-pushed
the
try-fix
branch
2 times, most recently
from
838e6f9 to
c8ebd5d
Compare
afc163
reviewed
Apr 28, 2018
src/util.js
Outdated
| // the following keys found need to be removed from test regression | ||
| 'attribute', | ||
| 'value', | ||
| 'onClick', |
Contributor
Author
There was a problem hiding this comment.
那就只好在rc-select里做一个if判断了，我马上放个pr你看下
Contributor
Author
There was a problem hiding this comment.
😢 这样table的test还会fail..
Contributor
Author
|
@afc163 改过来了，但是得做：react-component/select#295 and ant-design/ant-design@0ab57c9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.