On MenuItem, set the role to none if the role is null or none.
#155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will remove the implied `listitem` role of the `<li />`. https://www.w3.org/TR/wai-aria-practices-1.1/examples/menubar/menubar-1/menubar-1.html
cdeutsch
commented
Jun 7, 2018
| 'aria-selected': props.isSelected, | ||
| }; | ||
| } else if (props.role === null) { | ||
| } else if (props.role === null || props.role === 'none') { |
Contributor
Author
There was a problem hiding this comment.
I left the null option in here for backward compatibility, but I'm also ok with removing it.
Ran into a case where there is a readonly list displayed by a dropdown and the `<li />` role should be "reset" to `listitem`.
picodoth
approved these changes
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the implied
listitemrole of the<li />.https://www.w3.org/TR/wai-aria-practices-1.1/examples/menubar/menubar-1/menubar-1.html
Related to this original issue:
ant-design/ant-design#10095
Sorry, I'm just learning all about proper accessibility.