support onMouseEnter/onMouseLeave for MenuItem and SubMenu
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 61ab5ab on superRaytin:feature/mouse-event-on-submenu-and-menuitem into * on react-component:master*. |
src/MenuItem.jsx
Outdated
| } | ||
| }, 30); | ||
| if (props.mode === 'inline') { | ||
| if (props.onMouseLeave) { |
Member
There was a problem hiding this comment.
已经有 defaultProps 了，不需要再做检测了吧。。
Member
|
|
Changes Unknown when pulling 2b173f8 on superRaytin:feature/mouse-event-on-submenu-and-menuitem into * on react-component:master*. |
Contributor
Author
|
@afc163 vertical 和 horizonal 的子菜单是 popup，支持的话会不会有点混乱。。 其他事件是指所有的 Mouse Events 吗？ |
Member
|
也不算支持，算是修复所有原生事件传递。 |
Contributor
Author
那所有 rc 组件都需要吧，需要通盘来考虑 @yiminghe |
Member
|
只加必要的就行了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MenuItem/SubMenu 增加
onMouseEnter/onMouseLeave事件，只在mode: inline时生效。ant-design/ant-design#1445