-
-
Notifications
You must be signed in to change notification settings - Fork 261
refactor: rc-menu with accessibility
#385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 95.64% 99.83% +4.18%
==========================================
Files 11 24 +13
Lines 919 608 -311
Branches 274 148 -126
==========================================
- Hits 879 607 -272
+ Misses 40 1 -39
Continue to review full report at Codecov.
|
|
Thanks for your work on this @zombieJ. Is there a way to prevent the aria-hidden element being added to the DOM? The upgrade to antd 4.16 has caused many issues in our app. Our component tests now return duplicate elements and nested Preventing the hidden component being attached to the DOM would prevent both of our issues. |
Need more test for this.