fix: pass label to getItemIcon to fix missing aria-label
#299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes several accessibility warnings related to the jumper caused by a missing `aria-label`. The fixes can be observed in the `itemRender` and `jumper` stories in Storybook.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/pagination/o64uiwyqz |
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 3 3
Lines 327 327
Branches 113 113
=======================================
Hits 299 299
Misses 28 28
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for creating this library! This fixes an a11y warning I ran into in my application.
Commit Summary
This fixes several accessibility warnings related to the jumper caused
by a missing
aria-label. The fixes can be observed in theitemRenderandjumperstories in Storybook.Screenshots
And the missing
aria-label: