Skip to content

feat: simple Pagination cant emit onChange when change page #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2021
Merged

feat: simple Pagination cant emit onChange when change page #350

merged 4 commits into from
Nov 5, 2021

Conversation

@Dreamcreative
Copy link
Contributor

handle ant-design

#32659

@vercel
Copy link

vercel bot commented Nov 3, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/pagination/73tWyF1HxXEFzPuNRhfQ3KR4XxRt
✅ Preview: https://pagination-git-fork-dreamcreative-pagina-fa5ac5-react-component.vercel.app

afc163
afc163 reviewed Nov 3, 2021
View reviewed changes
tests/jumper.test.js Outdated
// input.simulate('blur');
// expect(wrapper.state().current).toBe(10);
// expect(onChange).not.toBeCalled();
// });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update it other than remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!!!

@afc163
Copy link
Member

afc163 commented Nov 4, 2021

ci broken

@codecov
Copy link

codecov bot commented Nov 4, 2021 •
edited
Loading

Codecov Report

Merging #350 (14e2f2f) into master (ca84b62) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   92.40%   92.55%   +0.15%     
==========================================
  Files           3        3              
  Lines         329      336       +7     
  Branches      113      116       +3     
==========================================
+ Hits          304      311       +7     
  Misses         25       25
Impacted Files Coverage Δ
src/Pagination.jsx 91.25% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca84b62...14e2f2f. Read the comment docs.

@Dreamcreative
Copy link
Contributor Author

@afc163 How can I stop this warning

@afc163
Copy link
Member

afc163 commented Nov 4, 2021

Please check codecov result.

图片

@Dreamcreative
Copy link
Contributor Author

i'm sorry, i think i had ran test in wrong way !!!

@afc163 afc163 merged commit 0906a90 into react-component:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afc163 afc163 afc163 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dreamcreative @afc163