Skip to content

Conversation

@kerm1it
Copy link
Member

@kerm1it kerm1it commented Oct 14, 2020

格式化值统一使用 formatValue 方法,防止有的 format 是函数,然后报错(https://github.com/ant-design/ant-design/issues/27155)。

@vercel
Copy link

vercel bot commented Oct 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/picker/2xqn71rb8
✅ Preview: https://picker-git-optimize-format-value.react-component.vercel.app

@kerm1it kerm1it requested review from afc163 and zombieJ October 14, 2020 14:40
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #156 into master will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files          45       45              
  Lines        1999     1998       -1     
  Branches      588      596       +8     
==========================================
- Hits         1991     1990       -1     
  Misses          6        6              
  Partials        2        2              
Impacted Files Coverage Δ
src/panels/MonthPanel/MonthHeader.tsx 100.00% <ø> (ø)
src/panels/QuarterPanel/QuarterHeader.tsx 100.00% <ø> (ø)
src/panels/DatePanel/DateHeader.tsx 83.33% <50.00%> (-1.67%) ⬇️
src/panels/MonthPanel/MonthBody.tsx 91.30% <50.00%> (ø)
src/RangePicker.tsx 100.00% <100.00%> (ø)
src/panels/DatePanel/DateBody.tsx 96.00% <100.00%> (ø)
src/panels/QuarterPanel/QuarterBody.tsx 100.00% <100.00%> (ø)
src/panels/TimePanel/TimeHeader.tsx 100.00% <100.00%> (ø)
src/panels/YearPanel/YearBody.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95cb621...05a00d2. Read the comment docs.

@kerm1it
Copy link
Member Author

kerm1it commented Oct 14, 2020

覆盖率下降是因为格式化的原因,应该不影响。

@zombieJ zombieJ merged commit 0b50241 into master Oct 15, 2020
@zombieJ zombieJ deleted the optimize-format-value branch October 15, 2020 02:20
@zombieJ
Copy link
Member

zombieJ commented Oct 15, 2020

+ rc-picker@2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants